Implement UI consistency in legacy RN layout APIs#43579

Closed

rubennorte wants to merge 3 commits into

facebook:mainfrom

rubennorte:export-D55077309

rubennorte commented Mar 20, 2024

Contributor

Summary:
Changelog: [internal]

This updates all the legacy layout APIs in React Native to make use of the UI consistency mechanism introduced in Fabric (if available, otherwise the behavior is the same we have now — we consume the latest version of the tree available).

Differential Revision: D55077309

facebook-github-bot added CLA Signed p: Facebook Partner labels

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077309

facebook-github-bot added the fb-exported label

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077309

rubennorte force-pushed the export-D55077309 branch from fe562b2 to 62730a8 Compare

March 20, 2024 18:21

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077309

rubennorte force-pushed the export-D55077309 branch from 62730a8 to dccea56 Compare

March 20, 2024 18:50

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077309

rubennorte force-pushed the export-D55077309 branch from dccea56 to 0806157 Compare

March 20, 2024 18:57

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077309

rubennorte force-pushed the export-D55077309 branch from 0806157 to a749cc3 Compare

March 20, 2024 19:42

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077309

rubennorte force-pushed the export-D55077309 branch from a749cc3 to e9ff53c Compare

March 20, 2024 23:15

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077309

rubennorte force-pushed the export-D55077309 branch from e9ff53c to 7c6a757 Compare

March 20, 2024 23:23

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077309

rubennorte force-pushed the export-D55077309 branch from 7c6a757 to 4cdabc7 Compare

March 20, 2024 23:38

analysis-bot commented Mar 21, 2024 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	18,442,123	+270,775
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	21,811,330	+270,848
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 274faf4
Branch: main

facebook-github-bot commented Mar 21, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077309

rubennorte force-pushed the export-D55077309 branch from 4cdabc7 to 6b55a0e Compare

March 21, 2024 10:33

rubennorte force-pushed the export-D55077309 branch from aa043ba to 19310e6 Compare

March 21, 2024 11:45

facebook-github-bot commented Mar 21, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077309

rubennorte force-pushed the export-D55077309 branch from 19310e6 to 1d92fda Compare

March 21, 2024 14:27

facebook-github-bot commented Mar 21, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077309

facebook-github-bot commented Mar 21, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077309

rubennorte force-pushed the export-D55077309 branch from 1d92fda to 5dbc98f Compare

March 21, 2024 14:39

facebook-github-bot commented Mar 22, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077309

rubennorte force-pushed the export-D55077309 branch from 5dbc98f to 50cd3a1 Compare

March 22, 2024 16:11

facebook-github-bot commented Mar 22, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077309

rubennorte force-pushed the export-D55077309 branch from 50cd3a1 to 0a350bb Compare

March 22, 2024 16:18

facebook-github-bot commented Mar 25, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077309

rubennorte force-pushed the export-D55077309 branch from 0a350bb to 64188a8 Compare

March 25, 2024 11:22

facebook-github-bot commented Mar 25, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077309

rubennorte force-pushed the export-D55077309 branch from 64188a8 to a72e662 Compare

March 25, 2024 12:00

rubennorte and others added 3 commits

March 25, 2024 05:06


          Implement UI consistency in JS thread

30dac47

Differential Revision: D55024832


          Implement UI consistency in DOM methods

ef28086

Differential Revision: D55077311


          Implement UI consistency in legacy RN layout APIs (facebook#43579)

938670c

Summary:
Pull Request resolved: facebook#43579

Changelog: [internal]

This updates all the legacy layout APIs in React Native to make use of the UI consistency mechanism introduced in Fabric (if available, otherwise the behavior is the same we have now — we consume the latest version of the tree available).

Reviewed By: sammy-SC

Differential Revision: D55077309

facebook-github-bot commented Mar 25, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55077309

rubennorte force-pushed the export-D55077309 branch from a72e662 to 938670c Compare

March 25, 2024 12:09

facebook-github-bot closed this in

04562dd

facebook-github-bot added the Merged label

facebook-github-bot commented Mar 25, 2024

Contributor

This pull request has been merged in 04562dd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner