Enable synchronous state update dispatching behind a flag#43580

Closed

rubennorte wants to merge 4 commits into

facebook:mainfrom

rubennorte:export-D55083029

rubennorte commented Mar 20, 2024

Contributor

Summary:
Changelog: [internal]

This introduces a new feature flag to commit state updates synchronously from the UI thread (generally) instead of dispatching them to the JS thread to be processed there. We can do this now because we introduced a UI consistency mechanism in D55024832 to JS would see a consistent revision during the execution of a specific task.

Reviewed By: sammy-SC

Differential Revision: D55083029

facebook-github-bot added CLA Signed p: Facebook Partner labels

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55083029

facebook-github-bot added the fb-exported label

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55083029

rubennorte force-pushed the export-D55083029 branch from 56aa253 to a8adc43 Compare

March 20, 2024 18:23

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55083029

rubennorte force-pushed the export-D55083029 branch from a8adc43 to be220fa Compare

March 20, 2024 18:50

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55083029

rubennorte force-pushed the export-D55083029 branch from be220fa to 8e2ad77 Compare

March 20, 2024 18:58

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55083029

rubennorte force-pushed the export-D55083029 branch from 8e2ad77 to 3e24f95 Compare

March 20, 2024 19:43

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55083029

rubennorte force-pushed the export-D55083029 branch from 3e24f95 to 7702266 Compare

March 20, 2024 23:16

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55083029

rubennorte force-pushed the export-D55083029 branch from 7702266 to 757efa0 Compare

March 20, 2024 23:25

facebook-github-bot commented Mar 20, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55083029

rubennorte force-pushed the export-D55083029 branch from 757efa0 to 3a53f57 Compare

March 20, 2024 23:38

analysis-bot commented Mar 21, 2024 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	18,446,490	+274,915
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	21,815,631	+274,975
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 95a8c99
Branch: main

facebook-github-bot commented Mar 21, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55083029

rubennorte force-pushed the export-D55083029 branch from 3a53f57 to 0b23ee8 Compare

March 21, 2024 10:35

facebook-github-bot commented Mar 21, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55083029

rubennorte closed this

rubennorte force-pushed the export-D55083029 branch from 41516ae to 1c52d38 Compare

March 21, 2024 11:38

facebook-github-bot commented Mar 21, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55083029

facebook-github-bot commented Mar 21, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55083029

facebook-github-bot commented Mar 21, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55083029

facebook-github-bot commented Mar 22, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55083029

facebook-github-bot commented Mar 22, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55083029

facebook-github-bot commented Mar 25, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55083029

facebook-github-bot commented Mar 25, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55083029

1 similar comment

facebook-github-bot commented Mar 25, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55083029

rubennorte and others added 4 commits

March 25, 2024 07:00


          Implement UI consistency in JS thread

b240099

Differential Revision: D55024832


          Implement UI consistency in DOM methods

dbb71f4

Differential Revision: D55077311


          Implement UI consistency in legacy RN layout APIs

ec5afe4

Differential Revision: D55077309


          Enable synchronous state update dispatching behind a flag (facebook#4…

7968b7c

…3580)

Summary:
Pull Request resolved: facebook#43580

Changelog: [internal]

This introduces a new feature flag to commit state updates synchronously from the UI thread (generally) instead of dispatching them to the JS thread to be processed there. We can do this now because we introduced a UI consistency mechanism in D55024832 to JS would see a consistent revision during the execution of a specific task.

Reviewed By: sammy-SC

Differential Revision: D55083029

facebook-github-bot commented Mar 25, 2024

Contributor

This pull request was exported from Phabricator. Differential Revision: D55083029

rubennorte reopened this

facebook-github-bot closed this in

f446cf6

facebook-github-bot commented Mar 25, 2024

Contributor

This pull request has been merged in f446cf6.

facebook-github-bot added the Merged label

TatianaKapos mentioned this pull request

Integration 4/6/2024 (a05466c5b) microsoft/react-native-windows#13208

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner