Skip to content

add missing dependency to core library#43606

Closed
sammy-SC wants to merge 1 commit into
facebook:mainfrom
sammy-SC:export-D55240313
Closed

add missing dependency to core library#43606
sammy-SC wants to merge 1 commit into
facebook:mainfrom
sammy-SC:export-D55240313

Conversation

@sammy-SC

@sammy-SC sammy-SC commented Mar 22, 2024

Copy link
Copy Markdown
Contributor

Differential Revision: D55240313

D54805494 broke CircleCI because it didn't list all of the required dependencies in CMakeList.txt

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 22, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55240313

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55240313

@analysis-bot

analysis-bot commented Mar 22, 2024

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 18,171,495 +61,421
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,540,591 +61,431
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 15a5638
Branch: main

@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55240313

Summary:

changelog: [internal]

D54805494 broke CircleCI because it didn't list all of the required dependencies in CMakeList.txt

Reviewed By: cortinico

Differential Revision: D55240313
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55240313

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 22, 2024
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request has been merged in e90b975.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants