Fix use-after-free in AsyncEventBeat#43618
Closed
tnovak wants to merge 1 commit into
Closed
Conversation
Summary: Both common and Android implementations of AsyncEventBeat use weak_ptrs to determine if the object is still valid before invoking the callback. Move the write to `isBeatCallbackScheduled_` down so it's protected by that same check. Changelog: [Internal] Reviewed By: javache, NickGerleman Differential Revision: D55226529
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55226529 |
Base commit: ad9f0b0 |
Contributor
|
This pull request has been merged in 00725fa. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Both common and Android implementations of AsyncEventBeat use weak_ptrs
to determine if the object is still valid before invoking the callback.
Move the write to
isBeatCallbackScheduled_down so it's protected bythat same check.
Changelog: [Internal]
Reviewed By: javache, NickGerleman
Differential Revision: D55226529