Skip to content

Back out "Add onUserLeaveHint support to ReactActivityDelegate #43488"#43642

Closed
rubennorte wants to merge 1 commit into
facebook:mainfrom
rubennorte:export-D55324557
Closed

Back out "Add onUserLeaveHint support to ReactActivityDelegate #43488"#43642
rubennorte wants to merge 1 commit into
facebook:mainfrom
rubennorte:export-D55324557

Conversation

@rubennorte

@rubennorte rubennorte commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

Summary: This change broke some apps at Meta. Reverting until we figure out a safe way to land this.

Differential Revision: D55324557

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 25, 2024
@facebook-github-bot

facebook-github-bot commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55324557

@rubennorte @facebook-github-bot
Back out "Add onUserLeaveHint support to ReactActivityDelegate facebo…
b097421 
…ok#43488"

Summary:
Changelog: [internal]

This change broke some apps at Meta. Reverting until we figure out a safe way to land this.

Differential Revision: D55324557
@facebook-github-bot

facebook-github-bot commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55324557

@cortinico

cortinico commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

This is being reverted because of this error:
434218817_2543331965867630_775261948160717462_n (1)

@cortinico cortinico mentioned this pull request Mar 25, 2024
Closed
@analysis-bot

analysis-bot commented Mar 25, 2024

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 18,450,576 -5
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,815,628 -4,094
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 8a2cf68
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 25, 2024
@facebook-github-bot

facebook-github-bot commented Mar 25, 2024

Copy link
Copy Markdown
Contributor

This pull request has been merged in 152f5f4.

@behenate

behenate commented Mar 26, 2024

Copy link
Copy Markdown
Contributor

@cortinico Is it possible for you to check more in depth how this is causing the crash in your apps? From my perspective it's really hard to figure out why onUserLeaveHint breaks something with overriding modules 🤔

@cortinico

cortinico commented Mar 26, 2024

Copy link
Copy Markdown
Contributor

@cortinico Is it possible for you to check more in depth how this is causing the crash in your apps? From my perspective it's really hard to figure out why onUserLeaveHint breaks something with overriding modules 🤔

I need to investigate a bit further to understand what's happenign. Could you re-send the same PR again? Sorry for the back-n-forth

@behenate

behenate commented Mar 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

@cortinico Sure! Thanks for the help with this PR even though we it keeps getting reverted 😅

Edit: reopened the PR #43658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rubennorte @facebook-github-bot @cortinico @analysis-bot @behenate