Include native module for DOM APIs by default in all apps using the new architecture#43653
Closed
rubennorte wants to merge 1 commit into
Closed
Include native module for DOM APIs by default in all apps using the new architecture#43653rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55365252 |
rubennorte
force-pushed
the
export-D55365252
branch
from
5701d73 to
ca1c454
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55365252 |
rubennorte
force-pushed
the
export-D55365252
branch
from
ca1c454 to
93d08ef
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55365252 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55365252 |
rubennorte
force-pushed
the
export-D55365252
branch
from
93d08ef to
7ea128c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55365252 |
rubennorte
force-pushed
the
export-D55365252
branch
from
7ea128c to
edda7e6
Compare
Base commit: 2af1da4 |
rubennorte
force-pushed
the
export-D55365252
branch
from
edda7e6 to
0be8d0a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55365252 |
…ew architecture (facebook#43653) Summary: Changelog: [internal] This will allow us to clean up some code in `UIManager` (using methods in the native module instead) and prepare to use the DOM APIs in OSS behind a feature flag. This doesn't enable the DOM APIs in OSS, only the native module. Reviewed By: javache Differential Revision: D55365252
rubennorte
force-pushed
the
export-D55365252
branch
from
0be8d0a to
849012f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55365252 |
Contributor
|
This pull request has been merged in 3da5858. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Changelog: [internal]
Differential Revision: D55365252