Expose ScrollView's persistentScrollIndicator and horizontal to the C++ side props#43655
Closed
rshest wants to merge 1 commit into
Closed
Expose ScrollView's persistentScrollIndicator and horizontal to the C++ side props#43655rshest wants to merge 1 commit into
rshest wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55367445 |
…++ side props (facebook#43655) Summary: ## Changelog: [Internal] - The corresponding prop `ScrollBar.persistentScrollIndicator` was only passed to the Android platform code an `ScrollBar.horizontal` wasn't passed to native at all. On other platforms we need those props to be available on the C++ side, so this exposes them to the corresponding C++ ScrollViewProps. Differential Revision: D55367445
rshest
force-pushed
the
export-D55367445
branch
from
1d386dc to
8d963d1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55367445 |
Contributor
|
This pull request has been merged in a4592fd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] -
The corresponding prop
ScrollBar.persistentScrollIndicatorwas only passed to the Android platform code anScrollBar.horizontalwasn't passed to native at all.On other platforms we need those props to be available on the C++ side, so this exposes them to the corresponding C++ ScrollViewProps.
Differential Revision: D55367445