fix: remove loadSourceForBridge in RCTRootViewFactory

[okwasniewski]

Summary:

This PR removes forward declaration of loadSourceForBridge methods from the RCTRootViewFactory as it was causing an issue on old architecture, where the RedBox wouldn't popup when metro wasn't running.

As stated by @Kudo here:

the problem was coming from the implementation

react-native/packages/react-native/React/CxxBridge/RCTCxxBridge.mm

Lines 519 to 540 in 00725fa

	if ([self.delegate respondsToSelector:@selector(loadSourceForBridge:onProgress:onComplete:)]) {
	[self.delegate loadSourceForBridge:_parentBridge onProgress:onProgress onComplete:onSourceLoad];
	} else if ([self.delegate respondsToSelector:@selector(loadSourceForBridge:withBlock:)]) {
	[self.delegate loadSourceForBridge:_parentBridge withBlock:onSourceLoad];
	} else if (!self.bundleURL) {
	NSError *error = RCTErrorWithMessage(
	@"No bundle URL present.\n\nMake sure you're running a packager "
	"server or have included a .jsbundle file in your application bundle.");
	onSourceLoad(error, nil);
	} else {
	__weak RCTCxxBridge *weakSelf = self;
	[RCTJavaScriptLoader loadBundleAtURL:self.bundleURL
	onProgress:onProgress
	onComplete:^(NSError *error, RCTSource *source) {
	if (error) {
	[weakSelf handleError:error];
	return;
	}
	onSourceLoad(error, source);
	}];
	}
	}

we should dynamically override loadSourceForBridge:onProgress:onComplete: and loadSourceForBridge:withBlock: in RCTRootViewFactory only when AppDelegate override it. one way to achieve this might be tricky that we may need to override respondsToSelector:.

otherwise, we could just skip the loadSourceForBridge:onProgress:onComplete: and loadSourceForBridge:withBlock: support.

There is no straight forward solution to implement this without some hacks so I'm removing this forward block for now.

Changelog:

[IOS] [FIXED] - remove loadSourceForBridge in RCTRootViewFactory

Test Plan:

CI Green

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	18,483,534	+16
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	21,856,615	-7
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 41a9664
Branch: main

[facebook-github-bot]

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[okwasniewski]

Hey, can you guys let me know what the issues are on internal linter? I'll fix them

[cortinico]

Hey, can you guys let me know what the issues are on internal linter? I'll fix them

Sorry I was out due to public holidays. I've fixed it for you, we should be able to merge it soon

[facebook-github-bot]

@cortinico merged this pull request in 0c02b26.