Skip to content

Add forwardRef call to Button Component #43666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chiaramooney wants to merge 1 commit into from
Closed

Add forwardRef call to Button Component #43666

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/react-native/Libraries/Components/Button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,10 @@ type ButtonProps = $ReadOnly<{|
```
*/

const Button: React.AbstractComponent<ButtonProps> = (props: ButtonProps) => {
const Button: React.AbstractComponent<
ButtonProps,
React.ElementRef<typeof TouchableNativeFeedback | typeof TouchableOpacity>,
> = React.forwardRef((props: ButtonProps, ref) => {
const {
accessibilityLabel,
accessibilityState,
Expand Down Expand Up @@ -374,15 +377,16 @@ const Button: React.AbstractComponent<ButtonProps> = (props: ButtonProps) => {
testID={testID}
disabled={disabled}
onPress={onPress}
touchSoundDisabled={touchSoundDisabled}>
touchSoundDisabled={touchSoundDisabled}
ref={ref}>
<View style={buttonStyles}>
<Text style={textStyles} disabled={disabled}>
{formattedTitle}
</Text>
</View>
</Touchable>
);
};
});

Button.displayName = 'Button';

Expand Down