DisabledDevSupportManager -> ReleaseDevSupportManager#43667
Closed
arushikesarwani94 wants to merge 1 commit into
Closed
DisabledDevSupportManager -> ReleaseDevSupportManager#43667arushikesarwani94 wants to merge 1 commit into
arushikesarwani94 wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55388403 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55388403 |
arushikesarwani94
force-pushed
the
export-D55388403
branch
from
d18f218 to
114ccb9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55388403 |
arushikesarwani94
force-pushed
the
export-D55388403
branch
from
114ccb9 to
60f3afb
Compare
Summary: Pull Request resolved: facebook#43667 Renaming `DisabledDevSupportManager` -> `ReleaseDevSupportManager` to avoid confusion since this is only initialized in Release variant https://github.com/facebook/react-native/blob/bb02049a6af2c83c3fa633a5eb098bae1135b4a4/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.java#L181-L187 allow-large-files Changelog: [Internal] Internal Reviewed By: fkgozali, cortinico Differential Revision: D55388403
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55388403 |
arushikesarwani94
force-pushed
the
export-D55388403
branch
from
60f3afb to
57bea9a
Compare
Base commit: 575507d |
Contributor
|
This pull request has been merged in 41a9664. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Renaming
DisabledDevSupportManager->ReleaseDevSupportManagerto avoid confusion since this is only initialized in Release variantreact-native/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.java
Lines 181 to 187 in bb02049
Changelog:
[Internal] Internal
Differential Revision: D55388403