Skip to content

Introduce DevSupportManager.openDebugger() method #43685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
motiz88 wants to merge 1 commit into from
Closed

Introduce DevSupportManager.openDebugger() method #43685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/react-native/ReactAndroid/api/ReactAndroid.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2114,6 +2114,7 @@ public abstract class com/facebook/react/devsupport/DevSupportManagerBase : com/
public fun isPackagerRunning (Lcom/facebook/react/devsupport/interfaces/PackagerStatusCallback;)V
public fun onNewReactContextCreated (Lcom/facebook/react/bridge/ReactContext;)V
public fun onReactInstanceDestroyed (Lcom/facebook/react/bridge/ReactContext;)V
public fun openDebugger ()V
public fun processErrorCustomizers (Landroid/util/Pair;)Landroid/util/Pair;
public fun registerErrorCustomizer (Lcom/facebook/react/devsupport/interfaces/ErrorCustomizer;)V
public fun reloadJSFromServer (Ljava/lang/String;)V
Expand Down Expand Up @@ -2170,6 +2171,7 @@ public class com/facebook/react/devsupport/DisabledDevSupportManager : com/faceb
public fun loadSplitBundleFromServer (Ljava/lang/String;Lcom/facebook/react/devsupport/interfaces/DevSplitBundleCallback;)V
public fun onNewReactContextCreated (Lcom/facebook/react/bridge/ReactContext;)V
public fun onReactInstanceDestroyed (Lcom/facebook/react/bridge/ReactContext;)V
public fun openDebugger ()V
public fun processErrorCustomizers (Landroid/util/Pair;)Landroid/util/Pair;
public fun registerErrorCustomizer (Lcom/facebook/react/devsupport/interfaces/ErrorCustomizer;)V
public fun reloadJSFromServer (Ljava/lang/String;)V
Expand Down Expand Up @@ -2382,6 +2384,7 @@ public abstract interface class com/facebook/react/devsupport/interfaces/DevSupp
public abstract fun loadSplitBundleFromServer (Ljava/lang/String;Lcom/facebook/react/devsupport/interfaces/DevSplitBundleCallback;)V
public abstract fun onNewReactContextCreated (Lcom/facebook/react/bridge/ReactContext;)V
public abstract fun onReactInstanceDestroyed (Lcom/facebook/react/bridge/ReactContext;)V
public abstract fun openDebugger ()V
public abstract fun processErrorCustomizers (Landroid/util/Pair;)Landroid/util/Pair;
public abstract fun registerErrorCustomizer (Lcom/facebook/react/devsupport/interfaces/ErrorCustomizer;)V
public abstract fun reloadJSFromServer (Ljava/lang/String;)V
Expand Down
13 changes: 7 additions & 6 deletions ...ative/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,12 +384,7 @@ public void onOptionSelected() {
if (!isConnected) {
disabledItemKeys.add(debuggerItemString);
}
options.put(
debuggerItemString,
() ->
mDevServerHelper.openDebugger(
mCurrentContext,
mApplicationContext.getString(R.string.catalyst_open_debugger_error)));
options.put(debuggerItemString, () -> openDebugger());
}

options.put(
Expand Down Expand Up @@ -1163,4 +1158,10 @@ private void compatRegisterReceiver(
context.registerReceiver(receiver, filter);
}
}

@Override
public void openDebugger() {
mDevServerHelper.openDebugger(
mCurrentContext, mApplicationContext.getString(R.string.catalyst_open_debugger_error));
}
}
3 changes: 3 additions & 0 deletions ...e/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,4 +204,7 @@ public void handleException(Exception e) {
public @Nullable SurfaceDelegate createSurfaceDelegate(String moduleName) {
return null;
}

@Override
public void openDebugger() {}
}
3 changes: 3 additions & 0 deletions ...eactAndroid/src/main/java/com/facebook/react/devsupport/interfaces/DevSupportManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,4 +128,7 @@ interface PackagerLocationCustomizer {
*/
@Nullable
SurfaceDelegate createSurfaceDelegate(String moduleName);

/** Attempt to open the JS debugger on the host machine. */
void openDebugger();
}