fix: version checker not considering nightlies#43712
Closed
tido64 wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Base commit: d0cac87 |
zeyap
reviewed
Mar 29, 2024
Contributor
|
@zeyap has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
zeyap
added a commit
to zeyap/react-native
that referenced
this pull request
Apr 2, 2024
…book#43744) Summary: ## Changelog: Use semver to do version comparison in cli instead of custom fn `parseVersion` ~~adding test for PR change in facebook#43712 Differential Revision: D55600458
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
Summary: Pull Request resolved: #43744 ## Changelog: [General] [Changed] - Use semver to do version comparison in cli instead of custom fn `parseVersion` ~~adding test for PR change in #43712 Reviewed By: NickGerleman Differential Revision: D55600458 fbshipit-source-id: eaffa3e89696b90fd354aefaba79e035d180a0b5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix version checker not considering nightlies:
Changelog:
[GENERAL] [FIXED] - Fix version checker not considering nightlies
Test Plan:
On a recent nightly version, run any cli command.