From cd22df381d0e3bc40e1a55c5a1f66ba302c0021e Mon Sep 17 00:00:00 2001 From: Tommy Nguyen <4123478+tido64@users.noreply.github.com> Date: Fri, 29 Mar 2024 09:17:24 +0100 Subject: [PATCH] Fix version checker not considering nightlies --- packages/react-native/cli.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/react-native/cli.js b/packages/react-native/cli.js index 53c7e47df571..459213d4c517 100755 --- a/packages/react-native/cli.js +++ b/packages/react-native/cli.js @@ -56,6 +56,11 @@ async function getLatestVersion(registryHost = DEFAULT_REGISTRY_HOST) { }); } +function parseVersion(version) { + const [major, minor = 0, patch = 0] = version.split('-')[0].split('.'); + return major * 1000000 + minor * 1000 + patch; +} + /** * Warn when users are using `npx react-native init`, to raise awareness of the changes from RFC 0759. * @@ -129,7 +134,7 @@ async function main() { if (isNpxRuntime && !process.env.SKIP && currentVersion !== HEAD) { try { const latest = await getLatestVersion(); - if (latest !== currentVersion) { + if (parseVersion(latest) > parseVersion(currentVersion)) { const msg = ` ${chalk.bold.yellow('WARNING:')} You should run ${chalk.white.bold( 'npx react-native@latest',