Skip to content

fix: version checker not considering nightlies #43712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tido64 wants to merge 1 commit into from
Closed

fix: version checker not considering nightlies #43712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/react-native/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ async function getLatestVersion(registryHost = DEFAULT_REGISTRY_HOST) {
});
}

function parseVersion(version) {
const [major, minor = 0, patch = 0] = version.split('-')[0].split('.');
return major * 1000000 + minor * 1000 + patch;
}

/**
* Warn when users are using `npx react-native init`, to raise awareness of the changes from RFC 0759.
*
Expand Down Expand Up @@ -129,7 +134,7 @@ async function main() {
if (isNpxRuntime && !process.env.SKIP && currentVersion !== HEAD) {
try {
const latest = await getLatestVersion();
if (latest !== currentVersion) {
if (parseVersion(latest) > parseVersion(currentVersion)) {
Comment thread
tido64 marked this conversation as resolved.
const msg = `
${chalk.bold.yellow('WARNING:')} You should run ${chalk.white.bold(
'npx react-native@latest',
Expand Down