Skip to content

Migrate JSRuntimeFactory to Kotlin#43748

Closed
arushikesarwani94 wants to merge 1 commit into
facebook:mainfrom
arushikesarwani94:export-D55605824
Closed

Migrate JSRuntimeFactory to Kotlin#43748
arushikesarwani94 wants to merge 1 commit into
facebook:mainfrom
arushikesarwani94:export-D55605824

Conversation

@arushikesarwani94

@arushikesarwani94 arushikesarwani94 commented Apr 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

JSRuntimeFactory.java -> JSRuntimeFactory.kt

Differential Revision: D55605824

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Apr 1, 2024
@facebook-github-bot

facebook-github-bot commented Apr 1, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55605824

@facebook-github-bot

facebook-github-bot commented Apr 2, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55605824

@facebook-github-bot

facebook-github-bot commented Apr 2, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55605824

@facebook-github-bot

facebook-github-bot commented Apr 2, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55605824

@facebook-github-bot

facebook-github-bot commented Apr 2, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55605824

@facebook-github-bot

facebook-github-bot commented Apr 2, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55605824

@facebook-github-bot

facebook-github-bot commented Apr 2, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55605824

@facebook-github-bot

facebook-github-bot commented Apr 2, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55605824

@arushikesarwani94 @facebook-github-bot
Migrate JSRuntimeFactory to Kotlin (facebook#43748)
a760e91 
Summary:
JSRuntimeFactory.java -> JSRuntimeFactory.kt

Pull Request resolved: facebook#43748

Changelog: [Internal]

Reviewed By: cortinico, rshest

Differential Revision: D55605824
@facebook-github-bot

facebook-github-bot commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D55605824

@analysis-bot

analysis-bot commented Apr 3, 2024

Copy link
Copy Markdown
Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 18,910,452 -10
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,279,098 -20
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 3559a6c
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 4, 2024
@facebook-github-bot

facebook-github-bot commented Apr 4, 2024

Copy link
Copy Markdown
Contributor

This pull request has been merged in 99c8011.

@github-actions

github-actions Bot commented Apr 4, 2024

Copy link
Copy Markdown

This pull request was successfully merged by @arushikesarwani94 in 99c8011.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arushikesarwani94 @facebook-github-bot @analysis-bot