Back out "fix: prevent error when react extension was already created"#43753
Closed
NickGerleman wants to merge 1 commit into
Closed
Back out "fix: prevent error when react extension was already created"#43753NickGerleman wants to merge 1 commit into
NickGerleman wants to merge 1 commit into
Conversation
Summary:
New build failures when this was merged seem likely related.
```
FAILURE: Build failed with an exception.
* Where:
Build file '/root/react-native/packages/react-native/ReactAndroid/build.gradle.kts' line: 784
* What went wrong:
Script compilation errors:
Line 784: react {
^ Unresolved reference: react
Line 787: libraryName = "rncore"
^ Unresolved reference: libraryName
Line 788: jsRootDir = file("../src")
^ Unresolved reference: jsRootDir
```
Changelog: [Internal]
Reviewed By: arushikesarwani94
Differential Revision: D55618667
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55618667 |
Contributor
|
This pull request has been merged in 2477fbc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
New build failures when this was merged seem likely related.
Changelog: [Internal]
Reviewed By: arushikesarwani94
Differential Revision: D55618667