Do not attempt to call Class.forName in OSS#43816
Closed
cortinico wants to merge 2 commits into
Closed
Conversation
…tlin Summary: This moves a lot of classes from Java to Kotlin from the `package com.facebook.react.views.modal` Changelog: [Internal] [Changed] - Convert several classes inside `com.facebook.react.views.modal` to Kotlin Differential Revision: D55692067
Summary: We should not attempt to load generated classes by the Annotation processor in OSS because we simply don't run it, so those classes will fail to load. I'm short-circuiting the logic here. This is sustainability work as we got a report for this in OSS a while ago and I never got the time to work on it. Changelog: [Internal] [Changed] - Do not attempt to call Class.forName in OSS Differential Revision: D55693479
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55693479 |
Base commit: e180072 |
Contributor
|
This pull request has been merged in 26cc8cd. |
|
This pull request was successfully merged by @cortinico in 26cc8cd. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We should not attempt to load generated classes by the Annotation processor in OSS because we simply don't run it, so those classes will fail to load. I'm short-circuiting the logic here.
This is sustainability work as we got a report for this in OSS a while ago and I never got the time to work on it.
Changelog:
[Internal] [Changed] - Do not attempt to call Class.forName in OSS
Differential Revision: D55693479