add feature flag to enable explicit yoga node cleaning in TextInput#43913
Closed
sammy-SC wants to merge 1 commit into
Closed
add feature flag to enable explicit yoga node cleaning in TextInput#43913sammy-SC wants to merge 1 commit into
sammy-SC wants to merge 1 commit into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55751341 |
Base commit: 7facb32 |
…acebook#43913) Summary: changelog: [internal] We have this turned on in ParagraphShadowNode, let's roll it out for TextInput as well. I came across this while profiling scroll performance when TextInput is part of the view hierarchy. Reviewed By: javache Differential Revision: D55751341
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55751341 |
sammy-SC
force-pushed
the
export-D55751341
branch
from
0391fb9 to
88f4fd7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55751341 |
Contributor
|
This pull request has been merged in 35d5754. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
We have this turned on in ParagraphShadowNode, let's roll it out for TextInput as well.
I came across this while profiling scroll performance when TextInput is part of the view hierarchy.
Reviewed By: javache
Differential Revision: D55751341