extend StateReconciliationTests#44020
Closed
sammy-SC wants to merge 5 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55926491 |
Base commit: 5e9ed14 |
sammy-SC
force-pushed
the
export-D55926491
branch
from
fd2ba5c to
25da453
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55926491 |
sammy-SC
force-pushed
the
export-D55926491
branch
from
25da453 to
ba13310
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55926491 |
sammy-SC
force-pushed
the
export-D55926491
branch
from
ba13310 to
eccdce4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55926491 |
sammy-SC
force-pushed
the
export-D55926491
branch
from
eccdce4 to
41a9d62
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55926491 |
…44016) Summary: changelog: [internal] Add option to set traits when node is created or cloned via ShadowNodeFragment. This is a pre-requisite for new state reconciliation algorithm. Reviewed By: rubennorte Differential Revision: D55691094
…ook#44017) Summary: changelog: [internal] Add an option to mark all nodes clone indirectly by `ShadowNode::cloneTree`. This is a pre-requisite for new state reconciliation algorithm. It will be used to mark part of shadow tree that was affected by native state update. Reviewed By: rubennorte Differential Revision: D55745323
) Summary: changelog: [internal] New trait ClonedByNativeStateUpdate is used to mark the path that was cloned by native state update. This is a pre-requisite for new state reconciliation algorithm. It will mark part of shadow tree that was affected by native state update. Reviewed By: rubennorte Differential Revision: D55922776
Summary: changelog: [internal] use size_t instead of int32_t so that caller of `ShadowNode::replaceChild` does not need to cast. Reviewed By: rubennorte Differential Revision: D55923333
Summary: changelog: [internal] This diff only adds more tests for state reconciliation to cover more cases. Thanks to this, I discovered bugs in my previous implementation of cloneless state progression. Reviewed By: rubennorte Differential Revision: D55926491
sammy-SC
force-pushed
the
export-D55926491
branch
from
41a9d62 to
8178e4b
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Apr 11, 2024
Summary: changelog: [internal] This diff only adds more tests for state reconciliation to cover more cases. Thanks to this, I discovered bugs in my previous implementation of cloneless state progression. Reviewed By: rubennorte Differential Revision: D55926491
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55926491 |
Contributor
|
This pull request has been merged in 223c039. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
This diff only adds more tests for state reconciliation to cover more cases.
Thanks to this, I discovered bugs in my previous implementation of cloneless state progression.
Reviewed By: rubennorte
Differential Revision: D55926491