New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rotateX and rotateY transforms to Android Views . #4413

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
8 participants
@felipemartim

felipemartim commented Nov 29, 2015

Setting rotateX and rotateY for Android Views.

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Nov 29, 2015

By analyzing the blame information on this pull request, we identified @browniefed, @chirag04 and @kmagiera to be potential reviewers.

facebook-github-bot commented Nov 29, 2015

By analyzing the blame information on this pull request, we identified @browniefed, @chirag04 and @kmagiera to be potential reviewers.

perspectiveMatrix
);
var transposedInversePerspectiveMatrix = MatrixMath.transpose4x4(

This comment has been minimized.

@felipemartim

felipemartim Nov 29, 2015

inverse3x3 and transpose4x4 don't exist on MatrixMath object. Also, this code is only reachable when the platform is Android, as can be seen in processTransform.js:89.

@felipemartim

felipemartim Nov 29, 2015

inverse3x3 and transpose4x4 don't exist on MatrixMath object. Also, this code is only reachable when the platform is Android, as can be seen in processTransform.js:89.

@felipemartim felipemartim changed the title from Implementing Android's rotateX and rotateY transforms. to Add rotateX and rotateY transforms to Android Views . Nov 29, 2015

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot Nov 29, 2015

@felipemartim updated the pull request.

facebook-github-bot commented Nov 29, 2015

@felipemartim updated the pull request.

@felipemartim

This comment has been minimized.

Show comment
Hide comment
@felipemartim

felipemartim commented Nov 29, 2015

Print 1
Print 2
Print 3

@ide

This comment has been minimized.

Show comment
Hide comment
@ide

ide Nov 29, 2015

Collaborator

The code LGTM cc @mkonicek

Collaborator

ide commented Nov 29, 2015

The code LGTM cc @mkonicek

@satya164

This comment has been minimized.

Show comment
Hide comment
@satya164

satya164 Nov 30, 2015

Collaborator

Awesome work @felipemartim .

Collaborator

satya164 commented Nov 30, 2015

Awesome work @felipemartim .

@chirag04

This comment has been minimized.

Show comment
Hide comment
@chirag04

chirag04 Nov 30, 2015

Collaborator

👍

Collaborator

chirag04 commented Nov 30, 2015

👍

1 similar comment
@mbinge

This comment has been minimized.

Show comment
Hide comment
@mbinge

mbinge commented Nov 30, 2015

👍

@kmagiera

This comment has been minimized.

Show comment
Hide comment
@kmagiera

kmagiera Nov 30, 2015

Contributor

This looks good, leaving for @mkonicek to merge

Contributor

kmagiera commented Nov 30, 2015

This looks good, leaving for @mkonicek to merge

@mbinge

This comment has been minimized.

Show comment
Hide comment
@mbinge

mbinge Dec 9, 2015

Any updates on this @mkonicek ?

mbinge commented Dec 9, 2015

Any updates on this @mkonicek ?

@mkonicek

This comment has been minimized.

Show comment
Hide comment
@mkonicek

mkonicek Dec 9, 2015

Contributor

Sorry for the delay. Too many PRs in the queue.

Contributor

mkonicek commented Dec 9, 2015

Sorry for the delay. Too many PRs in the queue.

@mkonicek

This comment has been minimized.

Show comment
Hide comment
@mkonicek
Contributor

mkonicek commented Dec 9, 2015

@facebook-github-bot

This comment has been minimized.

Show comment
Hide comment
@facebook-github-bot

facebook-github-bot commented Dec 9, 2015

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/505299736307914/int_phab to review.

@ghost ghost closed this in 96553cf Dec 10, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment