From 4577bff9cd856d195df03a6ed745006c02b52729 Mon Sep 17 00:00:00 2001 From: Edmond Chui Date: Wed, 8 May 2024 18:26:07 -0700 Subject: [PATCH] extract param type (#44498) Summary: Changelog: [internal] Quick refactor to reduce commit noise in the following diff in the stack Differential Revision: D57140480 --- .../src/inspector-proxy/DeviceEventReporter.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/dev-middleware/src/inspector-proxy/DeviceEventReporter.js b/packages/dev-middleware/src/inspector-proxy/DeviceEventReporter.js index 79c8aa166040..5fe9b4bc83dc 100644 --- a/packages/dev-middleware/src/inspector-proxy/DeviceEventReporter.js +++ b/packages/dev-middleware/src/inspector-proxy/DeviceEventReporter.js @@ -31,6 +31,11 @@ type RequestMetadata = $ReadOnly<{ frontendUserAgent: string | null, }>; +type ResponseMetadata = $ReadOnly<{ + pageId: string | null, + frontendUserAgent: string | null, +}>; + class DeviceEventReporter { #eventReporter: EventReporter; @@ -72,10 +77,7 @@ class DeviceEventReporter { logResponse( res: CDPResponse<>, origin: 'device' | 'proxy', - metadata: $ReadOnly<{ - pageId: string | null, - frontendUserAgent: string | null, - }>, + metadata: ResponseMetadata, ): void { const pendingCommand = this.#pendingCommands.get(res.id); if (!pendingCommand) {