From 44281b32875dec81a6c3c3ec05826d2ae28aa3a2 Mon Sep 17 00:00:00 2001 From: wh201906 Date: Sat, 20 Jul 2024 19:49:40 +0800 Subject: [PATCH 1/2] Add upper case keys to the debug key handler --- .../src/commands/start/attachKeyHandlers.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/packages/community-cli-plugin/src/commands/start/attachKeyHandlers.js b/packages/community-cli-plugin/src/commands/start/attachKeyHandlers.js index 0db4df40b9ec..0bb3437380c1 100644 --- a/packages/community-cli-plugin/src/commands/start/attachKeyHandlers.js +++ b/packages/community-cli-plugin/src/commands/start/attachKeyHandlers.js @@ -46,14 +46,17 @@ export default function attachKeyHandlers({ const onPress = async (key: string) => { switch (key) { case 'r': + case 'R': logger.info('Reloading connected app(s)...'); messageSocket.broadcast('reload', null); break; case 'd': + case 'D': logger.info('Opening Dev Menu...'); messageSocket.broadcast('devMenu', null); break; case 'i': + case 'I': logger.info('Opening app on iOS...'); execa( 'npx', @@ -66,6 +69,7 @@ export default function attachKeyHandlers({ ).stdout?.pipe(process.stdout); break; case 'a': + case 'A': logger.info('Opening app on Android...'); execa( 'npx', @@ -78,6 +82,7 @@ export default function attachKeyHandlers({ ).stdout?.pipe(process.stdout); break; case 'j': + case 'J': if (!experimentalDebuggerFrontend) { return; } From d6e16f4365af58949e8fdff19f803b862b2bb138 Mon Sep 17 00:00:00 2001 From: wh201906 Date: Tue, 23 Jul 2024 18:17:09 +0800 Subject: [PATCH 2/2] Alternative way --- .../src/commands/start/attachKeyHandlers.js | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/packages/community-cli-plugin/src/commands/start/attachKeyHandlers.js b/packages/community-cli-plugin/src/commands/start/attachKeyHandlers.js index 0bb3437380c1..0393c9c14370 100644 --- a/packages/community-cli-plugin/src/commands/start/attachKeyHandlers.js +++ b/packages/community-cli-plugin/src/commands/start/attachKeyHandlers.js @@ -44,19 +44,16 @@ export default function attachKeyHandlers({ }; const onPress = async (key: string) => { - switch (key) { + switch (key.toLowerCase()) { case 'r': - case 'R': logger.info('Reloading connected app(s)...'); messageSocket.broadcast('reload', null); break; case 'd': - case 'D': logger.info('Opening Dev Menu...'); messageSocket.broadcast('devMenu', null); break; case 'i': - case 'I': logger.info('Opening app on iOS...'); execa( 'npx', @@ -69,7 +66,6 @@ export default function attachKeyHandlers({ ).stdout?.pipe(process.stdout); break; case 'a': - case 'A': logger.info('Opening app on Android...'); execa( 'npx', @@ -82,7 +78,6 @@ export default function attachKeyHandlers({ ).stdout?.pipe(process.stdout); break; case 'j': - case 'J': if (!experimentalDebuggerFrontend) { return; }