From a910ce0c3b37b191b5f1b5c364195d4124b60bfd Mon Sep 17 00:00:00 2001 From: Nick Gerleman Date: Sat, 27 Jul 2024 09:50:40 -0700 Subject: [PATCH] Disable "setAndroidLayoutDirection" in default feature flags Summary: Let's turn this off, for clients where the feature flag isn't wired to a config, until the issue with `removeClippedSubviews` is resolved. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D60273063 --- .../internal/featureflags/ReactNativeFeatureFlagsDefaults.kt | 4 ++-- .../react/featureflags/ReactNativeFeatureFlagsDefaults.h | 4 ++-- .../scripts/featureflags/ReactNativeFeatureFlags.config.js | 2 +- .../src/private/featureflags/ReactNativeFeatureFlags.js | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt index c229e8d69b91..a6110c048cfb 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt @@ -4,7 +4,7 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @generated SignedSource<> + * @generated SignedSource<> */ /** @@ -79,7 +79,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi override fun loadVectorDrawablesOnImages(): Boolean = false - override fun setAndroidLayoutDirection(): Boolean = true + override fun setAndroidLayoutDirection(): Boolean = false override fun useImmediateExecutorInAndroidBridgeless(): Boolean = false diff --git a/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h b/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h index d8a87d083736..b393427143c8 100644 --- a/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h +++ b/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h @@ -4,7 +4,7 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @generated SignedSource<<436dd66c962b5bd70cc574d573ddfc0a>> + * @generated SignedSource<> */ /** @@ -140,7 +140,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider { } bool setAndroidLayoutDirection() override { - return true; + return false; } bool useImmediateExecutorInAndroidBridgeless() override { diff --git a/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js b/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js index f092601a56ad..186ff0fe2234 100644 --- a/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js +++ b/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js @@ -174,7 +174,7 @@ const definitions: FeatureFlagDefinitions = { 'Adds support for loading vector drawable assets in the Image component (only on Android)', }, setAndroidLayoutDirection: { - defaultValue: true, + defaultValue: false, description: 'Propagate layout direction to Android views.', }, useImmediateExecutorInAndroidBridgeless: { diff --git a/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js b/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js index f396bc2e38f8..4ad21b4250cd 100644 --- a/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js +++ b/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js @@ -4,7 +4,7 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @generated SignedSource<> + * @generated SignedSource<<46ea8a3a51ac64342484cc230727fca3>> * @flow strict-local */ @@ -258,7 +258,7 @@ export const loadVectorDrawablesOnImages: Getter = createNativeFlagGett /** * Propagate layout direction to Android views. */ -export const setAndroidLayoutDirection: Getter = createNativeFlagGetter('setAndroidLayoutDirection', true); +export const setAndroidLayoutDirection: Getter = createNativeFlagGetter('setAndroidLayoutDirection', false); /** * Invoke callbacks immediately on the ReactInstance rather than going through a background thread for synchronization */