From d68dd677d45030c08130d6de1826827516f186c5 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Wed, 7 Aug 2024 14:03:27 -0700 Subject: [PATCH] Introduce ReactNativeNewArchitectureFeatureFlagsDefaults (#45922) Summary: Introduce the ReactNativeNewArchitectureFeatureFlagsDefaults class, which initializes default values for ReactNativeFeatureFlags when the New architecture is enabled. This class is meant to be overrode by ReactNativeNewArchitectureFeatureFlagsDefaults or others apps migrating to the new architecture. changelog: [internal] internal Differential Revision: D60861873 --- ...tiveNewArchitectureFeatureFlagsDefaults.kt | 43 +++++++++++++++++++ 1 file changed, 43 insertions(+) create mode 100644 packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeNewArchitectureFeatureFlagsDefaults.kt diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeNewArchitectureFeatureFlagsDefaults.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeNewArchitectureFeatureFlagsDefaults.kt new file mode 100644 index 000000000000..1fdabc7660b6 --- /dev/null +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeNewArchitectureFeatureFlagsDefaults.kt @@ -0,0 +1,43 @@ +// (c) Meta Platforms, Inc. and affiliates. Confidential and proprietary. +@file:Suppress("DEPRECATION") // We want to use ReactFeatureFlags here specifically + +package com.facebook.react.internal.featureflags + +import com.facebook.react.config.ReactFeatureFlags + +/** + * This class initializes default values for ReactNativeFeatureFlags when the New architecture is + * enabled. This class is meant to be overrode only by internal apps migrating to the new + * architecture. + * + * NOTE: Be aware that as a side effect this class also modifies static fields in {@link + * com.facebook.react.config.ReactFeatureFlags} when newArchitectureEnabled is true. + */ +public open class ReactNativeNewArchitectureFeatureFlagsDefaults( + private val newArchitectureEnabled: Boolean +) : ReactNativeFeatureFlagsDefaults() { + + init { + if (newArchitectureEnabled) { + // When the new architecture is enabled, we want to set the default values of the flags for + // Fabric, TurboModules and Bridgeless as enabled by default. + // ReactFeatureFlags is deprecated and will be deleted in 0.77, this code is temporary to + // support the new architecture before 0.77 cut. + ReactFeatureFlags.enableFabricRenderer = true + ReactFeatureFlags.useTurboModules = true + ReactFeatureFlags.enableBridgelessArchitecture = true + } + } + + override fun batchRenderingUpdatesInEventLoop(): Boolean = + newArchitectureEnabled || super.batchRenderingUpdatesInEventLoop() + + override fun useTurboModuleInterop(): Boolean = + newArchitectureEnabled || super.useTurboModuleInterop() + + override fun useModernRuntimeScheduler(): Boolean = true + + override fun enableMicrotasks(): Boolean = true + + override fun useNativeViewConfigsInBridgelessMode(): Boolean = true +}