From 0f41787f0517b758dbc484de915a8190f5e41370 Mon Sep 17 00:00:00 2001 From: David Vacca <515103+mdvacca@users.noreply.github.com> Date: Mon, 2 Dec 2024 16:09:20 -0800 Subject: [PATCH 1/2] Convert xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ComponentNameResolver to Kotlin Differential Revision: D66403041 --- ...ComponentNameResolver.java => ComponentNameResolver.kt} | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) rename packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/{ComponentNameResolver.java => ComponentNameResolver.kt} (71%) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ComponentNameResolver.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ComponentNameResolver.kt similarity index 71% rename from packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ComponentNameResolver.java rename to packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ComponentNameResolver.kt index fb9d15de2974..df8bda274992 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ComponentNameResolver.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ComponentNameResolver.kt @@ -5,13 +5,12 @@ * LICENSE file in the root directory of this source tree. */ -package com.facebook.react.uimanager; +package com.facebook.react.uimanager -import com.facebook.proguard.annotations.DoNotStripAny; +import com.facebook.proguard.annotations.DoNotStripAny @DoNotStripAny public interface ComponentNameResolver { - /* returns a list of all the component names that are registered in React Native. */ - String[] getComponentNames(); + public val componentNames: Array? } From b1f82f3b0ece9996cff87677ad59aeba5fc12372 Mon Sep 17 00:00:00 2001 From: David Vacca <515103+mdvacca@users.noreply.github.com> Date: Mon, 2 Dec 2024 16:09:20 -0800 Subject: [PATCH 2/2] Reduce visibility of ComponentNameResolver to internal Summary: ComponentNameResolver is meant to be used only internaly, we reduce its visbility to internal changelog: [Android][Breaking] Removed ComponentNameResolver from public API Reviewed By: javache Differential Revision: D66403218 --- packages/react-native/ReactAndroid/api/ReactAndroid.api | 4 ---- .../com/facebook/react/uimanager/ComponentNameResolver.kt | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/react-native/ReactAndroid/api/ReactAndroid.api b/packages/react-native/ReactAndroid/api/ReactAndroid.api index 0a3d08f46983..bfb7c6353ad3 100644 --- a/packages/react-native/ReactAndroid/api/ReactAndroid.api +++ b/packages/react-native/ReactAndroid/api/ReactAndroid.api @@ -4095,10 +4095,6 @@ public abstract class com/facebook/react/uimanager/BaseViewManagerDelegate : com public fun setProperty (Landroid/view/View;Ljava/lang/String;Ljava/lang/Object;)V } -public abstract interface class com/facebook/react/uimanager/ComponentNameResolver { - public abstract fun getComponentNames ()[Ljava/lang/String; -} - public final class com/facebook/react/uimanager/DisplayMetricsHolder { public static final field INSTANCE Lcom/facebook/react/uimanager/DisplayMetricsHolder; public static final fun getDisplayMetricsWritableMap (D)Lcom/facebook/react/bridge/WritableMap; diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ComponentNameResolver.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ComponentNameResolver.kt index df8bda274992..478a2e709ca8 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ComponentNameResolver.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ComponentNameResolver.kt @@ -10,7 +10,7 @@ package com.facebook.react.uimanager import com.facebook.proguard.annotations.DoNotStripAny @DoNotStripAny -public interface ComponentNameResolver { +internal interface ComponentNameResolver { /* returns a list of all the component names that are registered in React Native. */ public val componentNames: Array? }