From 4bdd1f910fae003f27ed4ccbe3762f8e39123c4f Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Mon, 23 Dec 2024 07:04:00 -0800 Subject: [PATCH 1/3] USe the debug APK instead of the release one Summary: For a mistake, the local E2E test we use to test a release is still pointing to the release APK instead of using the debug apk. This change fix that. The change has been manually applied to the release branches, for example [here](https://github.com/facebook/react-native/commit/385318bf6a83b124d9e8eb925932edff02115c85) ## Changelog [Internal] - use Debug apk instead of release one to test the release Reviewed By: robhogan Differential Revision: D67599760 --- scripts/release-testing/test-e2e-local.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/release-testing/test-e2e-local.js b/scripts/release-testing/test-e2e-local.js index 9ff312d84bf6..34661737815a 100644 --- a/scripts/release-testing/test-e2e-local.js +++ b/scripts/release-testing/test-e2e-local.js @@ -164,7 +164,7 @@ async function testRNTesterAndroid( exec(`unzip ${downloadPath} -d ${unzipFolder}`); let apkPath = path.join( unzipFolder, - `app-${argv.hermes === true ? 'hermes' : 'jsc'}-${emulatorArch}-release.apk`, + `app-${argv.hermes === true ? 'hermes' : 'jsc'}-${emulatorArch}-debug.apk`, ); exec(`adb install ${apkPath}`); From 845beec0874a77d4836c19adfa0603b1abb43b80 Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Mon, 23 Dec 2024 07:04:00 -0800 Subject: [PATCH 2/3] Fix typo in configuration Summary: The configuration to run E2E tests on maestro has a typo that was outputting a warning in CI: {F1974100056} ## Changelog [Internal] - Fix typo on E2E test configuration Differential Revision: D67599849 --- .github/actions/maestro-android/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/maestro-android/action.yml b/.github/actions/maestro-android/action.yml index cd402beb36a3..27ad1c7e5328 100644 --- a/.github/actions/maestro-android/action.yml +++ b/.github/actions/maestro-android/action.yml @@ -62,7 +62,7 @@ runs: api-level: 24 arch: x86 ram-size: '8192M' - heap-sizze: '4096M' + heap-size: '4096M' disk-size: '10G' cores: '4' disable-animations: false From 46d912308704c568b2e1d88832558231b98bcdc3 Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Mon, 23 Dec 2024 07:04:00 -0800 Subject: [PATCH 3/3] Do not install jq as it is already installed Summary: jq is already installed on M1 machines on GithubActions. There is no need to install it again and this is outputting a warning in CI: {F1974100065} ## Changelog: [Internal] - Do not install jq as it is already installed Differential Revision: D67599961 --- .github/actions/maestro-ios/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/maestro-ios/action.yml b/.github/actions/maestro-ios/action.yml index c8e0c7a7cd29..e71fd6d0c2c5 100644 --- a/.github/actions/maestro-ios/action.yml +++ b/.github/actions/maestro-ios/action.yml @@ -36,7 +36,7 @@ runs: shell: bash run: | brew tap facebook/fb - brew install facebook/fb/idb-companion jq + brew install facebook/fb/idb-companion - name: Set up JDK 11 uses: actions/setup-java@v2 with: