From 681fcc8f04aedbf99401d7d2abdf11d6299f8af0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rub=C3=A9n=20Norte?= Date: Wed, 5 Feb 2025 02:59:28 -0800 Subject: [PATCH] Fix testOnly behavior in CI Summary: Changelog: [internal] We refactored the public API of Fantom benchmarks in https://github.com/facebook/react-native/pull/49014 but that refactor broke test only mode, as we started overriding the options after setting them. This fixes that. Differential Revision: D69176983 --- packages/react-native-fantom/src/Benchmark.js | 33 ++++++++++--------- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/packages/react-native-fantom/src/Benchmark.js b/packages/react-native-fantom/src/Benchmark.js index 1216df128a97..5d3e4ad8fac8 100644 --- a/packages/react-native-fantom/src/Benchmark.js +++ b/packages/react-native-fantom/src/Benchmark.js @@ -60,8 +60,7 @@ export function suite( const benchOptions: BenchOptions = isTestOnly ? { - warmupIterations: 1, - warmupTime: 0, + warmup: false, iterations: 1, time: 0, } @@ -71,24 +70,26 @@ export function suite( benchOptions.throws = true; benchOptions.now = () => NativeCPUTime.getCPUTimeNanos() / 1000000; - if (suiteOptions.minIterations != null) { - benchOptions.iterations = suiteOptions.minIterations; - } + if (!isTestOnly) { + if (suiteOptions.minIterations != null) { + benchOptions.iterations = suiteOptions.minIterations; + } - if (suiteOptions.minDuration != null) { - benchOptions.time = suiteOptions.minDuration; - } + if (suiteOptions.minDuration != null) { + benchOptions.time = suiteOptions.minDuration; + } - if (suiteOptions.warmup != null) { - benchOptions.warmup = suiteOptions.warmup; - } + if (suiteOptions.warmup != null) { + benchOptions.warmup = suiteOptions.warmup; + } - if (suiteOptions.minWarmupDuration != null) { - benchOptions.warmupTime = suiteOptions.minWarmupDuration; - } + if (suiteOptions.minWarmupDuration != null) { + benchOptions.warmupTime = suiteOptions.minWarmupDuration; + } - if (suiteOptions.minWarmupIterations != null) { - benchOptions.warmupIterations = suiteOptions.minWarmupIterations; + if (suiteOptions.minWarmupIterations != null) { + benchOptions.warmupIterations = suiteOptions.minWarmupIterations; + } } const bench = new Bench(benchOptions);