Skip to content

Update non-codegen ViewManagerInterfaces to extend ViewManagerWithGeneratedInterface #49274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update non-codegen ViewManagerInterfaces to extend ViewManagerWithGeneratedInterface #49274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...droid/src/main/java/com/facebook/react/viewmanagers/AndroidPopupMenuManagerInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@
import android.view.View;
import androidx.annotation.Nullable;
import com.facebook.react.bridge.ReadableArray;
import com.facebook.react.uimanager.ViewManagerWithGeneratedInterface;

public interface AndroidPopupMenuManagerInterface<T extends View> {
public interface AndroidPopupMenuManagerInterface<T extends View> extends ViewManagerWithGeneratedInterface {
void setMenuItems(T view, @Nullable ReadableArray value);
void show(T view);
}
3 changes: 2 additions & 1 deletion .../src/main/java/com/facebook/react/viewmanagers/SampleNativeComponentManagerInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@
import android.view.View;
import androidx.annotation.Nullable;
import com.facebook.react.bridge.ReadableArray;
import com.facebook.react.uimanager.ViewManagerWithGeneratedInterface;

public interface SampleNativeComponentManagerInterface<T extends View> {
public interface SampleNativeComponentManagerInterface<T extends View> extends ViewManagerWithGeneratedInterface {
void setOpacity(T view, float value);
void setValues(T view, @Nullable ReadableArray value);
void changeBackgroundColor(T view, String color);
Expand Down
Loading