Skip to content

Re-land: Make RedBoxContentView internal #49596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+5 −14
Closed

Re-land: Make RedBoxContentView internal #49596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions packages/react-native/ReactAndroid/api/ReactAndroid.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2182,15 +2182,6 @@ public abstract interface class com/facebook/react/devsupport/ReactInstanceDevHe
public abstract fun toggleElementInspector ()V
}

public final class com/facebook/react/devsupport/RedBoxContentView : android/widget/LinearLayout, android/widget/AdapterView$OnItemClickListener {
public fun <init> (Landroid/content/Context;Lcom/facebook/react/devsupport/interfaces/DevSupportManager;Lcom/facebook/react/devsupport/interfaces/RedBoxHandler;)V
public final fun init ()V
public fun onItemClick (Landroid/widget/AdapterView;Landroid/view/View;IJ)V
public final fun refreshContentView ()V
public final fun resetReporting ()V
public final fun setExceptionDetails (Ljava/lang/String;[Lcom/facebook/react/devsupport/interfaces/StackFrame;)V
}

public class com/facebook/react/devsupport/ReleaseDevSupportManager : com/facebook/react/devsupport/interfaces/DevSupportManager {
public fun <init> ()V
public fun addCustomDevOption (Ljava/lang/String;Lcom/facebook/react/devsupport/interfaces/DevOptionHandler;)V
Expand Down
10 changes: 5 additions & 5 deletions ...eact-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/RedBoxContentView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ import org.json.JSONObject

/** Dialog for displaying JS errors in an eye-catching form (red box). */
@SuppressLint("ViewConstructor")
public class RedBoxContentView(
internal class RedBoxContentView(
context: Context?,
private val devSupportManager: DevSupportManager,
private val redBoxHandler: RedBoxHandler?,
Expand Down Expand Up @@ -190,7 +190,7 @@ public class RedBoxContentView(
}
}

public fun init() {
fun init() {
LayoutInflater.from(context).inflate(R.layout.redbox_view, this)

stackView =
Expand Down Expand Up @@ -220,12 +220,12 @@ public class RedBoxContentView(
}
}

public fun setExceptionDetails(title: String, stack: Array<StackFrame>) {
fun setExceptionDetails(title: String, stack: Array<StackFrame>) {
stackView.setAdapter(StackAdapter(title, stack))
}

/** Show the report button, hide the report textview and the loading indicator. */
public fun resetReporting() {
fun resetReporting() {
if (redBoxHandler?.isReportEnabled() == false) {
return
}
Expand All @@ -244,7 +244,7 @@ public class RedBoxContentView(
}

/** Refresh the content view with latest errors from dev support manager */
public fun refreshContentView() {
fun refreshContentView() {
val message: String? = devSupportManager.lastErrorTitle
val stack: Array<StackFrame> = devSupportManager.lastErrorStack ?: emptyArray()
val errorType: ErrorType = checkNotNull(devSupportManager.lastErrorType)
Expand Down
Loading