[android][kotlin] make DevServerHelper open #51323
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expo inherits from the DevServerHelper class, and needs it to be declared as open, the same goes for its public interface. This PR fixes this by adding the open to the class and to the methods that should be open
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cortinico merged this pull request in 2a0c1e6. |
Collaborator
|
This pull request was successfully merged by @chrfalch in 2a0c1e6 When will my fix make it into a release? | How to file a pick request? |
react-native-bot
pushed a commit
that referenced
this pull request
May 16, 2025
Summary: Expo inherits from the DevServerHelper class, and needs it to be declared as open, the same goes for its public interface. Expo is using this in `DevLauncherDevServerHelper` and overrides the methods: - getDevServerBundleURL - getDevServerSplitBundleURL - getSourceUrl - getSourceMapUrl - isPackagerRunning This PR fixes this by adding the open to the class and to the methods that should be open ## Changelog: [ANDROID] [FIXED] - Made DevServerHelper and its method open so that they can be overridden. Pull Request resolved: #51323 Test Plan: Verify that we can build against Expo. Reviewed By: cipolleschi Differential Revision: D74876479 Pulled By: cortinico fbshipit-source-id: 0037d6f7cee190a690ec3ec59896df04f46797b2
Collaborator
|
This pull request was successfully merged by @chrfalch in 84cf4d8 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Expo inherits from the DevServerHelper class, and needs it to be declared as open, the same goes for its public interface.
Expo is using this in
DevLauncherDevServerHelperand overrides the methods:This PR fixes this by adding the open to the class and to the methods that should be open
Changelog:
[ANDROID] [FIXED] - Made DevServerHelper and its method open so that they can be overridden.
Test Plan:
Verify that we can build against Expo.