From f264469677b2489368eeb914d924ac6e9759d91a Mon Sep 17 00:00:00 2001 From: Christoph Purrer Date: Wed, 20 Aug 2025 21:56:25 -0700 Subject: [PATCH] Align ImageManager and ImageFetcher requestImage API Summary: changelog: [internal] Differential Revision: D80679608 --- .../android/react/renderer/imagemanager/ImageFetcher.cpp | 2 +- .../platform/android/react/renderer/imagemanager/ImageFetcher.h | 2 +- .../android/react/renderer/imagemanager/ImageManager.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageFetcher.cpp b/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageFetcher.cpp index 26196d91515f..79eda9199dc1 100644 --- a/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageFetcher.cpp +++ b/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageFetcher.cpp @@ -15,8 +15,8 @@ namespace facebook::react { ImageRequest ImageFetcher::requestImage( const ImageSource& imageSource, - const ImageRequestParams& imageRequestParams, SurfaceId surfaceId, + const ImageRequestParams& imageRequestParams, Tag tag) const { auto fabricUIManager_ = contextContainer_->at>("FabricUIManager"); diff --git a/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageFetcher.h b/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageFetcher.h index 0fca962d903f..ae30fbe1be4a 100644 --- a/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageFetcher.h +++ b/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageFetcher.h @@ -20,8 +20,8 @@ class ImageFetcher { ImageRequest requestImage( const ImageSource& imageSource, - const ImageRequestParams& imageRequestParams, SurfaceId surfaceId, + const ImageRequestParams& imageRequestParams, Tag tag) const; private: diff --git a/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageManager.cpp b/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageManager.cpp index 54586e46e683..e8da36ba76ac 100644 --- a/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageManager.cpp +++ b/packages/react-native/ReactCommon/react/renderer/imagemanager/platform/android/react/renderer/imagemanager/ImageManager.cpp @@ -27,7 +27,7 @@ ImageRequest ImageManager::requestImage( Tag tag) const { if (ReactNativeFeatureFlags::enableImagePrefetchingAndroid()) { return static_cast(self_)->requestImage( - imageSource, imageRequestParams, surfaceId, tag); + imageSource, surfaceId, imageRequestParams, tag); } return {imageSource, nullptr, {}}; }