Fix codegen script phase error logging#56956
Conversation
|
Hi @fallintoplace! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary:
This fixes the
error()helper inpackages/react-native/scripts/react_native_pods_utils/script_phases.shso it logs messages instead of attempting to execute them as shell commands.The current implementation does:
That causes the error path to fail with
command not foundunderset -e, writes the shell error toSCRIPT_OUTPUT_FILE_0instead of the intended[Codegen] ...line, and truncates multi-part messages to$1.This change captures the full message with
$*, prints it to stdout, and appends the formatted[Codegen] ...line toSCRIPT_OUTPUT_FILE_0.Fixes #56955.
Changelog:
[IOS] [FIXED] - Fix codegen script phase error logging in
script_phases.shTest Plan:
Observed output: