Fix Android 15 text clipping with safe visual bounds measurement#57117
Open
TorinAsakura wants to merge 1 commit into
Open
Fix Android 15 text clipping with safe visual bounds measurement#57117TorinAsakura wants to merge 1 commit into
TorinAsakura wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #56402.
Fixes #57110.
Android 15+ can clip text whose visual glyph bounds are wider than its advance-based desired width. The previous visual-bounds path fixed that by enabling
setUseBoundsForWidth(true)on the finalStaticLayout, but that path also changed final layout behavior and was later removed after multiline and wrapping regressions.This keeps the final layout on the existing advance-based behavior, but uses an Android 15+ visual-bounds probe only when React Native needs to compute the desired width for
AT_MOSTorUNDEFINEDmeasure modes.EXACTLYcontinues to use the width from Yoga directly. The desired width is never allowed to shrink below the old advance-based width.Changelog:
[ANDROID] [FIXED] - Prevent Android 15+ text clipping without changing final StaticLayout bounds mode
Test Plan: