Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
don't clobber user-defined environment variables #7878
If I want to set
To test this, run
As a side note, running with babel-plugin-transform-inline-environment-variables in the top-level
For anybody who runs into this bug and doesn't feel like waiting for this to get merged, I wrote a quick babel plugin to remove assignments to
We need this to make sure React runs with the right flags. If we didn't have this, you'd be running all sort of potentially expensive checks in production!
How about making this first check if NODE_ENV is undefined and only doing our args.dev change if it hasn't been set yet.