Activity indicator: add size prop #8935

fadils · 2016-07-21T01:49:38Z

motivation

Previously, size can only accept either 'small' or 'large'. And to obtain a custom size, scale transformation is used. This is to let users to possibly pass number value directly to define ActivityIndicator's size.

Test plan

I have also modified the current example to reflect the new size prop in action.

ghost · 2016-07-21T01:49:46Z

By analyzing the blame information on this pull request, we identified @janicduplessis and @sebmarkbage to be potential reviewers.

janicduplessis · 2016-07-21T18:41:30Z

Examples/UIExplorer/js/ActivityIndicatorExample.js

+    }
+  },
+  {
+    title: 'Custom size (size: 31, scale transform: 1.5)',


Let's remove the scale example.

Will do @janicduplessis

janicduplessis · 2016-07-21T18:59:18Z

Have you tested this change on both iOS and Android? Also does changing the size like this actually scales up the indicator (as far as I remember it didn't on iOS and it is why we had use a scale transform).

satya164 · 2016-07-21T19:35:52Z

docs/IndicatorSize.md

@@ -0,0 +1,15 @@
+---


Do we need a separate docs page just for indicator size? Can we not include it in the same documentation as ActivityIndicator?

I think the case is because we use custom propType checker instead. Since I'm gonna revert it, this doc is will be better left out. Thanks!

eslint-bot · 2016-07-22T04:36:34Z

Examples/UIExplorer/js/ActivityIndicatorExample.js

+    render() {
+      return (
+        <ActivityIndicator
+          style={styles.centering}


number This type is incompatible with string

@satya164 This is what I was talking about that flow keeps complaining, and thus I decided to create a custom propType checker instead.

@fadils Seems Flow is confused regarding the types. Can you add annotation to getDefaultProps so that flow doesn't try to infer the type and see if it fixes the issue?

type IndicatorSize = number | 'small' | 'large'; type DefaultProps = { animating: boolean; color: any; hidesWhenStopped: boolean; size: IndicatorSize; }

fadils · 2016-07-22T04:45:01Z

@janicduplessis, @satya164 not yet working on iOS. Should we create an Android specific prop for now? Maybe like customSize with @platform android ?

janicduplessis · 2016-07-22T05:05:58Z

Let's add a comment that says that passing a number to the size prop is only supported on Android in the prop documentation.

fadils · 2016-07-22T06:25:57Z

Alright. Any idea to make flow happy with this and consequently pass the CI?

satya164 · 2016-07-22T06:27:36Z

Will check the Flow thing in a while.

Previously, size can only accept either 'small' or 'large'. And to obtain a custom size, scale transformation is used. This is to let users to possibly pass number value to define ActivityIndicator's size. Not yet supported on iOS.

fadils · 2016-07-23T00:57:26Z

@satya164 the annotation works. Awesome!
@janicduplessis comments added. Examples updated too.

janicduplessis · 2016-07-23T01:04:49Z

Examples/UIExplorer/js/ActivityIndicatorExample.js

 ];

+if (Platform.OS === 'android') {


You can use the platform prop in the example object to avoid having to do this.

{ platform: 'android', title: '', ... }

Thanks! Didn't know about it.

@janicduplessis Previously, you suggested that we erase example that uses transformation.
I was thinking that if we put

{ platform: 'ios', ... }

then it would be a bit misleading as actually transformation can be done in Android as well.

If we didn't use platform, then the example will still be shown in Android, along with the custom size (with number) examples.

Any input?

Should we just keep it with something like this:

{ title: 'Custom size (transform scale: 1.5)', }

Let's keep the scale example and just add one with a custom size that is android only.

OK. Thanks!

eslint-bot · 2016-07-23T05:48:02Z

Examples/UIExplorer/js/ActivityIndicatorExample.js

@@ -24,6 +24,7 @@

 const React = require('react');
 const ReactNative = require('react-native');
+const Platform = require('Platform');


no-unused-vars: 'Platform' is defined but never used

fadils · 2016-07-28T21:14:10Z

@satya164 @janicduplessis is there anything else to ship this PR? I would be more than happy to add/change anything.

satya164 · 2016-07-28T21:22:06Z

@fadils Thanks for the ping.

@facebook-github-bot shipit

ghost · 2016-07-28T21:23:53Z

Thanks for importing. If you are an FB employee go to Phabricator to review internal test results.

Summary: **motivation** Previously, size can only accept either 'small' or 'large'. And to obtain a custom size, scale transformation is used. This is to let users to possibly pass number value directly to define ActivityIndicator's size. **Test plan** I have also modified the current example to reflect the new size prop in action. Closes facebook#8935 Differential Revision: D3637910 fbshipit-source-id: 6b8e1d4504964916df327b2d3eaaef1bb8cd5112

Summary: **motivation** Previously, size can only accept either 'small' or 'large'. And to obtain a custom size, scale transformation is used. This is to let users to possibly pass number value directly to define ActivityIndicator's size. **Test plan** I have also modified the current example to reflect the new size prop in action. Closes facebook/react-native#8935 Differential Revision: D3637910 fbshipit-source-id: 6b8e1d4504964916df327b2d3eaaef1bb8cd5112

Summary: **motivation** Previously, size can only accept either 'small' or 'large'. And to obtain a custom size, scale transformation is used. This is to let users to possibly pass number value directly to define ActivityIndicator's size. **Test plan** I have also modified the current example to reflect the new size prop in action. Closes facebook#8935 Differential Revision: D3637910 fbshipit-source-id: 6b8e1d4504964916df327b2d3eaaef1bb8cd5112

ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 21, 2016

fadils changed the title ~~Activity indicator/add size prop~~ Activity indicator: add size prop Jul 21, 2016

fadils force-pushed the ActivityIndicator/add-size-prop branch from f82158b to 369e201 Compare July 21, 2016 01:55

ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 21, 2016

janicduplessis reviewed Jul 21, 2016
View reviewed changes

satya164 reviewed Jul 21, 2016
View reviewed changes

satya164 added GH Review: needs-revision and removed GH Review: review-needed labels Jul 21, 2016

ghost added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 21, 2016

fadils force-pushed the ActivityIndicator/add-size-prop branch from 369e201 to 594eded Compare July 22, 2016 04:31

ghost added GH Review: review-needed and removed GH Review: needs-revision labels Jul 22, 2016

fadils force-pushed the ActivityIndicator/add-size-prop branch from 594eded to b0b27cd Compare July 22, 2016 04:35

eslint-bot reviewed Jul 22, 2016
View reviewed changes

ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 22, 2016

Accept number for size prop on Android

6ebcd81

Previously, size can only accept either 'small' or 'large'. And to obtain a custom size, scale transformation is used. This is to let users to possibly pass number value to define ActivityIndicator's size. Not yet supported on iOS.

fadils force-pushed the ActivityIndicator/add-size-prop branch from b0b27cd to 168666b Compare July 23, 2016 00:26

ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 23, 2016

janicduplessis reviewed Jul 23, 2016
View reviewed changes

ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 23, 2016

fadils force-pushed the ActivityIndicator/add-size-prop branch from 168666b to 384f654 Compare July 23, 2016 05:42

eslint-bot reviewed Jul 23, 2016
View reviewed changes

ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 23, 2016

Add examples with custom size number usage

a86576d

fadils force-pushed the ActivityIndicator/add-size-prop branch from 384f654 to a86576d Compare July 23, 2016 05:59

ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 23, 2016

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 28, 2016

ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jul 28, 2016

ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 28, 2016

ghost closed this in 63d15af Jul 28, 2016

janicduplessis mentioned this pull request Aug 5, 2016

added new sizes to ActivityIndicator #8640

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Activity indicator: add size prop #8935

Activity indicator: add size prop #8935

fadils commented Jul 21, 2016

ghost commented Jul 21, 2016

janicduplessis Jul 21, 2016

fadils Jul 22, 2016

janicduplessis commented Jul 21, 2016

satya164 Jul 21, 2016

fadils Jul 22, 2016

eslint-bot Jul 22, 2016

eslint-bot Jul 22, 2016

fadils Jul 22, 2016

satya164 Jul 22, 2016

satya164 Jul 22, 2016

fadils commented Jul 22, 2016

janicduplessis commented Jul 22, 2016

fadils commented Jul 22, 2016

satya164 commented Jul 22, 2016

fadils commented Jul 23, 2016

janicduplessis Jul 23, 2016

fadils Jul 23, 2016

fadils Jul 23, 2016

janicduplessis Jul 23, 2016

fadils Jul 23, 2016

eslint-bot Jul 23, 2016

fadils commented Jul 28, 2016

satya164 commented Jul 28, 2016

ghost commented Jul 28, 2016

Navigation Menu

Activity indicator: add size prop #8935

Activity indicator: add size prop #8935

Conversation

fadils commented Jul 21, 2016

ghost commented Jul 21, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

janicduplessis commented Jul 21, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fadils commented Jul 22, 2016

janicduplessis commented Jul 22, 2016

fadils commented Jul 22, 2016

satya164 commented Jul 22, 2016

fadils commented Jul 23, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fadils commented Jul 28, 2016

satya164 commented Jul 28, 2016

ghost commented Jul 28, 2016