From 040ca0fad7296fcc1fb9a01ebdb169fb32e1bc32 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Thu, 5 Sep 2019 19:25:51 +0100 Subject: [PATCH] Enable MessageLoop implementation by default (#16408) --- packages/scheduler/src/SchedulerFeatureFlags.js | 2 +- ...chedulerDOM-test.js => SchedulerRAFOld-test.internal.js} | 5 ++++- packages/scheduler/src/forks/SchedulerFeatureFlags.www.js | 6 +++--- 3 files changed, 8 insertions(+), 5 deletions(-) rename packages/scheduler/src/__tests__/{SchedulerDOM-test.js => SchedulerRAFOld-test.internal.js} (99%) diff --git a/packages/scheduler/src/SchedulerFeatureFlags.js b/packages/scheduler/src/SchedulerFeatureFlags.js index 98cf4bad14d74..7e17741524a40 100644 --- a/packages/scheduler/src/SchedulerFeatureFlags.js +++ b/packages/scheduler/src/SchedulerFeatureFlags.js @@ -10,5 +10,5 @@ export const enableSchedulerDebugging = false; export const enableIsInputPending = false; export const requestIdleCallbackBeforeFirstFrame = false; export const requestTimerEventBeforeFirstFrame = false; -export const enableMessageLoopImplementation = false; +export const enableMessageLoopImplementation = true; export const enableProfiling = __PROFILE__; diff --git a/packages/scheduler/src/__tests__/SchedulerDOM-test.js b/packages/scheduler/src/__tests__/SchedulerRAFOld-test.internal.js similarity index 99% rename from packages/scheduler/src/__tests__/SchedulerDOM-test.js rename to packages/scheduler/src/__tests__/SchedulerRAFOld-test.internal.js index dacfb53e9eb73..04e73a4e355fb 100644 --- a/packages/scheduler/src/__tests__/SchedulerDOM-test.js +++ b/packages/scheduler/src/__tests__/SchedulerRAFOld-test.internal.js @@ -16,7 +16,9 @@ type FrameTimeoutConfigType = { timePastFrameDeadline: ?number, }; -describe('SchedulerDOM', () => { +// Note: this is testing the implementation that we turned off. +// enableMessageLoopImplementation is true on master. +describe('SchedulerRAFOld', () => { let rAFCallbacks = []; let postMessageCallback; let postMessageEvents = []; @@ -101,6 +103,7 @@ describe('SchedulerDOM', () => { ), ); + require('scheduler/src/SchedulerFeatureFlags').enableMessageLoopImplementation = false; Scheduler = require('scheduler'); }); diff --git a/packages/scheduler/src/forks/SchedulerFeatureFlags.www.js b/packages/scheduler/src/forks/SchedulerFeatureFlags.www.js index 360be98e603f6..f4bebebf2c290 100644 --- a/packages/scheduler/src/forks/SchedulerFeatureFlags.www.js +++ b/packages/scheduler/src/forks/SchedulerFeatureFlags.www.js @@ -9,9 +9,9 @@ export const { enableIsInputPending, enableSchedulerDebugging, - requestIdleCallbackBeforeFirstFrame, - requestTimerEventBeforeFirstFrame, - enableMessageLoopImplementation, } = require('SchedulerFeatureFlags'); export const enableProfiling = __PROFILE__; +export const requestIdleCallbackBeforeFirstFrame = false; +export const requestTimerEventBeforeFirstFrame = false; +export const enableMessageLoopImplementation = true;