From 2243b40abad449fe90a9af10f592d0c5c52591d5 Mon Sep 17 00:00:00 2001 From: Ricky Date: Wed, 10 Apr 2024 10:34:34 -0400 Subject: [PATCH] [tests] assertLog before act in useEffectEvent (#28763) Fixes tests blocking https://github.com/facebook/react/pull/28737 --- .../react-reconciler/src/__tests__/useEffectEvent-test.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/react-reconciler/src/__tests__/useEffectEvent-test.js b/packages/react-reconciler/src/__tests__/useEffectEvent-test.js index 38cdae73f012..18e3a532946d 100644 --- a/packages/react-reconciler/src/__tests__/useEffectEvent-test.js +++ b/packages/react-reconciler/src/__tests__/useEffectEvent-test.js @@ -742,7 +742,7 @@ describe('useEffectEvent', () => { await act(() => ReactNoop.render(), ); - await act(() => jest.runAllTimers()); + assertLog(['Welcome to the general room!', 'Connected! theme: light']); expect(ReactNoop).toMatchRenderedOutput( , @@ -752,20 +752,17 @@ describe('useEffectEvent', () => { await act(() => ReactNoop.render(), ); - await act(() => jest.runAllTimers()); assertLog([ 'Welcome to the music room!', // should trigger a reconnect 'Connected! theme: light', ]); - expect(ReactNoop).toMatchRenderedOutput( , ); // change theme only await act(() => ReactNoop.render()); - await act(() => jest.runAllTimers()); // should not trigger a reconnect assertLog(['Welcome to the music room!']); expect(ReactNoop).toMatchRenderedOutput( @@ -776,7 +773,6 @@ describe('useEffectEvent', () => { await act(() => ReactNoop.render(), ); - await act(() => jest.runAllTimers()); assertLog([ 'Welcome to the travel room!', // should trigger a reconnect