From 4bc52ef0dfbb0389cc20b65cef0645afb7b85445 Mon Sep 17 00:00:00 2001 From: Luna Ruan Date: Thu, 3 Oct 2019 17:22:22 -0700 Subject: [PATCH] Revert "update hideOrUnhideAllChildren to hide portals that aren't wrapped in a host component (#16992)" (#17011) This reverts commit de2edc268db827f5110fc56cba240b7eb7301787. --- .../ReactDOMSuspensePlaceholder-test.js | 23 ------------------- .../src/ReactFiberCommitWork.js | 7 ------ 2 files changed, 30 deletions(-) diff --git a/packages/react-dom/src/__tests__/ReactDOMSuspensePlaceholder-test.js b/packages/react-dom/src/__tests__/ReactDOMSuspensePlaceholder-test.js index e82ef6eff44c..7f1d1c5db072 100644 --- a/packages/react-dom/src/__tests__/ReactDOMSuspensePlaceholder-test.js +++ b/packages/react-dom/src/__tests__/ReactDOMSuspensePlaceholder-test.js @@ -104,29 +104,6 @@ describe('ReactDOMSuspensePlaceholder', () => { expect(window.getComputedStyle(divs[2].current).display).toEqual('inline'); }); - it('hides and unhides child portals', async () => { - const portalContainer = document.createElement('div'); - function Component() { - return ReactDOM.createPortal(, portalContainer); - } - - function App() { - return ( - }> - - - - ); - } - - ReactDOM.render(, container); - expect(window.getComputedStyle(portalContainer).display).toEqual('none'); - - await advanceTimers(500); - Scheduler.unstable_flushAll(); - expect(window.getComputedStyle(portalContainer).display).toEqual('block'); - }); - it('hides and unhides timed out text nodes', async () => { function App() { return ( diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.js b/packages/react-reconciler/src/ReactFiberCommitWork.js index 2d337e24b44d..02b525a12391 100644 --- a/packages/react-reconciler/src/ReactFiberCommitWork.js +++ b/packages/react-reconciler/src/ReactFiberCommitWork.js @@ -645,13 +645,6 @@ function hideOrUnhideAllChildren(finishedWork, isHidden) { } else { unhideInstance(node.stateNode, node.memoizedProps); } - } else if (node.tag === HostPortal) { - const instance = node.stateNode.containerInfo; - if (isHidden) { - hideInstance(instance); - } else { - unhideInstance(instance, node.memoizedProps); - } } else if (node.tag === HostText) { const instance = node.stateNode; if (isHidden) {