From 7a7e792a6fd7668b37e475bf39e58fdb24e4ad81 Mon Sep 17 00:00:00 2001 From: Desmond Brand Date: Sat, 10 Aug 2019 13:44:23 -0700 Subject: [PATCH] Make SchedulerMinHeap flow strict (#16351) @acdlite while browsing Twitter, I saw [an opportunity][1] to do something more productive than browsing Twitter. [1]: https://twitter.com/acdlite/status/1160247965908234240 Test plan: `yarn flow-ci`, `yarn test-prod`, `yarn lint` --- packages/scheduler/src/SchedulerMinHeap.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/scheduler/src/SchedulerMinHeap.js b/packages/scheduler/src/SchedulerMinHeap.js index e74d5d6853b1..cbf7a649e962 100644 --- a/packages/scheduler/src/SchedulerMinHeap.js +++ b/packages/scheduler/src/SchedulerMinHeap.js @@ -4,7 +4,7 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @flow + * @flow strict */ type Heap = Array; @@ -38,7 +38,8 @@ export function pop(heap: Heap): Node | null { } } -function siftUp(heap, node, index) { +function siftUp(heap, node, i) { + let index = i; while (true) { const parentIndex = Math.floor((index - 1) / 2); const parent = heap[parentIndex]; @@ -54,7 +55,8 @@ function siftUp(heap, node, index) { } } -function siftDown(heap, node, index) { +function siftDown(heap, node, i) { + let index = i; const length = heap.length; while (index < length) { const leftIndex = (index + 1) * 2 - 1;