diff --git a/packages/react-devtools-core/src/standalone.js b/packages/react-devtools-core/src/standalone.js index 1516fa1c77b51..52e425cecdd12 100644 --- a/packages/react-devtools-core/src/standalone.js +++ b/packages/react-devtools-core/src/standalone.js @@ -40,11 +40,6 @@ let nodeWaitingToConnectHTML: string = ''; let projectRoots: Array = []; let statusListener: StatusListener = (message: string) => {}; -// Unlike browser extension users, people using the standalone have actively installed version 4, -// So we probably don't need to show them a changelog notice. -// We should give embedded users (e.g. Nuclide, Sonar) a way of showing this dialog though. -let showWelcomeToTheNewDevToolsDialog: boolean = false; - function setContentDOMNode(value: HTMLElement) { node = value; @@ -63,11 +58,6 @@ function setStatusListener(value: StatusListener) { return DevtoolsUI; } -function setShowWelcomeToTheNewDevToolsDialog(value: boolean) { - showWelcomeToTheNewDevToolsDialog = value; - return DevtoolsUI; -} - let bridge: FrontendBridge | null = null; let store: Store | null = null; let root = null; @@ -108,7 +98,6 @@ function reload() { bridge: ((bridge: any): FrontendBridge), canViewElementSourceFunction, showTabBar: true, - showWelcomeToTheNewDevToolsDialog, store: ((store: any): Store), warnIfLegacyBackendDetected: true, viewElementSourceFunction, @@ -318,7 +307,6 @@ const DevtoolsUI = { connectToSocket, setContentDOMNode, setProjectRoots, - setShowWelcomeToTheNewDevToolsDialog, setStatusListener, startServer, }; diff --git a/packages/react-devtools-extensions/src/main.js b/packages/react-devtools-extensions/src/main.js index fd81dc711d850..d12f002b843a0 100644 --- a/packages/react-devtools-extensions/src/main.js +++ b/packages/react-devtools-extensions/src/main.js @@ -161,7 +161,6 @@ function createPanelIfReactLoaded() { overrideTab, profilerPortalContainer, showTabBar: false, - showWelcomeToTheNewDevToolsDialog: true, store, viewElementSourceFunction, }), diff --git a/packages/react-devtools-shared/src/devtools/views/ShowWelcomeToTheNewDevToolsDialog.css b/packages/react-devtools-shared/src/devtools/views/ShowWelcomeToTheNewDevToolsDialog.css deleted file mode 100644 index 8168d947d2183..0000000000000 --- a/packages/react-devtools-shared/src/devtools/views/ShowWelcomeToTheNewDevToolsDialog.css +++ /dev/null @@ -1,26 +0,0 @@ -.Row { - display: flex; - flex-direction: row; - align-items: center; -} - -.Column { - display: flex; - flex-direction: column; - align-items: center; -} - -.Logo { - height: 4rem; - width: 4rem; - margin: 1rem; -} - -.Title { - font-size: var(--font-size-sans-large); - margin-bottom: 0.5rem; -} - -.ReleaseNotesLink { - color: var(--color-button-active); -} diff --git a/packages/react-devtools-shared/src/devtools/views/ShowWelcomeToTheNewDevToolsDialog.js b/packages/react-devtools-shared/src/devtools/views/ShowWelcomeToTheNewDevToolsDialog.js deleted file mode 100644 index a14f01a3cc434..0000000000000 --- a/packages/react-devtools-shared/src/devtools/views/ShowWelcomeToTheNewDevToolsDialog.js +++ /dev/null @@ -1,73 +0,0 @@ -/** - * Copyright (c) Facebook, Inc. and its affiliates. - * - * This source code is licensed under the MIT license found in the - * LICENSE file in the root directory of this source tree. - * - * @flow - */ - -import React, {Fragment, useContext, useEffect} from 'react'; -import {unstable_batchedUpdates as batchedUpdates} from 'react-dom'; -import {useLocalStorage} from './hooks'; -import {ModalDialogContext} from './ModalDialog'; -import ReactLogo from './ReactLogo'; -import {CHANGE_LOG_URL} from 'react-devtools-shared/src/constants'; - -import styles from './ShowWelcomeToTheNewDevToolsDialog.css'; - -const LOCAL_STORAGE_KEY = - 'React::DevTools::hasShownWelcomeToTheNewDevToolsDialog'; - -export default function ShowWelcomeToTheNewDevToolsDialog(_: {||}) { - const {dispatch} = useContext(ModalDialogContext); - const [ - hasShownWelcomeToTheNewDevToolsDialog, - setHasShownWelcomeToTheNewDevToolsDialog, - ] = useLocalStorage(LOCAL_STORAGE_KEY, false); - - useEffect( - () => { - if (!hasShownWelcomeToTheNewDevToolsDialog) { - batchedUpdates(() => { - setHasShownWelcomeToTheNewDevToolsDialog(true); - dispatch({ - canBeDismissed: true, - type: 'SHOW', - content: , - }); - }); - } - }, - [ - dispatch, - hasShownWelcomeToTheNewDevToolsDialog, - setHasShownWelcomeToTheNewDevToolsDialog, - ], - ); - - return null; -} - -function DialogContent(_: {||}) { - return ( - -
- -
-
Welcome to the new React DevTools!
-
- - Learn more - {' '} - about changes in this version. -
-
-
-
- ); -} diff --git a/packages/react-devtools-shell/src/devtools.js b/packages/react-devtools-shell/src/devtools.js index fed3834f62b46..ce623793a70c7 100644 --- a/packages/react-devtools-shell/src/devtools.js +++ b/packages/react-devtools-shell/src/devtools.js @@ -56,7 +56,6 @@ inject('dist/app.js', () => { createElement(DevTools, { browserTheme: 'light', showTabBar: true, - showWelcomeToTheNewDevToolsDialog: true, warnIfLegacyBackendDetected: true, }), );