From 9c2879674b098adf3a2e97845ac05acb856545d6 Mon Sep 17 00:00:00 2001 From: Ben Alpert Date: Mon, 28 Nov 2016 23:15:50 -0800 Subject: [PATCH] Fix fiber feature flag for ReactDOMProduction-test --- scripts/fiber/tests-failing.txt | 3 +++ scripts/fiber/tests-passing.txt | 1 - src/renderers/dom/__tests__/ReactDOMProduction-test.js | 4 +++- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/scripts/fiber/tests-failing.txt b/scripts/fiber/tests-failing.txt index 195917ac4e016..07e901f12c6c4 100644 --- a/scripts/fiber/tests-failing.txt +++ b/scripts/fiber/tests-failing.txt @@ -24,6 +24,9 @@ src/renderers/art/__tests__/ReactART-test.js * resolves refs before componentDidMount * resolves refs before componentDidUpdate +src/renderers/dom/__tests__/ReactDOMProduction-test.js +* should throw with an error code in production + src/renderers/dom/shared/__tests__/ReactDOM-test.js * throws in render() if the mount callback is not a function * throws in render() if the update callback is not a function diff --git a/scripts/fiber/tests-passing.txt b/scripts/fiber/tests-passing.txt index 34f94bffeee84..1188bad01a1f2 100644 --- a/scripts/fiber/tests-passing.txt +++ b/scripts/fiber/tests-passing.txt @@ -488,7 +488,6 @@ src/renderers/dom/__tests__/ReactDOMProduction-test.js * should use prod React * should handle a simple flow * should call lifecycle methods -* should throw with an error code in production src/renderers/dom/fiber/__tests__/ReactDOMFiber-test.js * should render strings as children diff --git a/src/renderers/dom/__tests__/ReactDOMProduction-test.js b/src/renderers/dom/__tests__/ReactDOMProduction-test.js index 4699975e360c2..c64a9411808e3 100644 --- a/src/renderers/dom/__tests__/ReactDOMProduction-test.js +++ b/src/renderers/dom/__tests__/ReactDOMProduction-test.js @@ -19,7 +19,9 @@ describe('ReactDOMProduction', () => { beforeEach(() => { __DEV__ = false; oldProcess = process; - global.process = {env: {NODE_ENV: 'production'}}; + global.process = { + env: Object.assign({}, process.env, {NODE_ENV: 'production'}), + }; jest.resetModuleRegistry(); React = require('React');