From f1231e60b0fda262cb617cd73a56d1e5bdbf0778 Mon Sep 17 00:00:00 2001 From: Ben Alpert Date: Mon, 22 Jul 2013 21:32:46 -0500 Subject: [PATCH] Call callbacks from setState in component context This is way more useful than the alternative. --- src/core/ReactUpdates.js | 2 +- src/core/__tests__/ReactUpdates-test.js | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/core/ReactUpdates.js b/src/core/ReactUpdates.js index 6c2d4f675ef7..c0b531785304 100644 --- a/src/core/ReactUpdates.js +++ b/src/core/ReactUpdates.js @@ -54,7 +54,7 @@ function batchedUpdates(callback) { component.performUpdateIfNecessary(); if (callbacks) { for (var j = 0; j < callbacks.length; j++) { - callbacks[j](); + callbacks[j].call(component); } } } diff --git a/src/core/__tests__/ReactUpdates-test.js b/src/core/__tests__/ReactUpdates-test.js index c48d5bb86c58..d73bad3739c8 100644 --- a/src/core/__tests__/ReactUpdates-test.js +++ b/src/core/__tests__/ReactUpdates-test.js @@ -237,6 +237,7 @@ describe('ReactUpdates', function() { ReactUpdates.batchedUpdates(function() { instance.setState({x: 1}, function() { instance.setState({x: 2}, function() { + expect(this).toBe(instance); innerCallbackRun = true; expect(instance.state.x).toBe(2); expect(updateCount).toBe(2);