diff --git a/src/isomorphic/classic/element/ReactElement.js b/src/isomorphic/classic/element/ReactElement.js index 6143d77c5868f..cecaf56b4a564 100644 --- a/src/isomorphic/classic/element/ReactElement.js +++ b/src/isomorphic/classic/element/ReactElement.js @@ -162,7 +162,7 @@ var ReactElement = function(type, key, ref, self, source, owner, props) { writable: false, value: source, }); - // Prevent the _owner attribute from breaking shallow renderer tests. + // _owner attribute would break shallow renderer equality checks. Object.defineProperty(element, '_owner', { configurable: false, enumerable: false, diff --git a/src/renderers/testing/ReactShallowRenderer.js b/src/renderers/testing/ReactShallowRenderer.js index 04d31b8138276..0826d7e532ae6 100644 --- a/src/renderers/testing/ReactShallowRenderer.js +++ b/src/renderers/testing/ReactShallowRenderer.js @@ -12,34 +12,31 @@ 'use strict'; -var React = require('react'); -var ReactTestRenderer = require('ReactTestRenderer'); +const React = require('react'); +const ReactTestRenderer = require('ReactTestRenderer'); -var emptyObject = require('fbjs/lib/emptyObject'); -var getNextDebugID = require('getNextDebugID'); -var invariant = require('fbjs/lib/invariant'); +const emptyFunction = require('fbjs/lib/emptyFunction'); +const emptyObject = require('fbjs/lib/emptyObject'); +const getNextDebugID = require('getNextDebugID'); +const invariant = require('fbjs/lib/invariant'); -const ShallowNodeMockComponent = ({children}) => { - return children ? React.Children.toArray(children) : []; -}; +const ShallowNodeMockComponent = ({children}) => React.Children.toArray(children); function createShallowNodeMock() { - var isFirst = true; - return element => { + let isFirst = true; + return function createNodeMock(element) { if (isFirst) { isFirst = false; return element.type; } return ShallowNodeMockComponent; - }; + } } function wrapElementWithContextProvider(element, context) { - function noop() {} - const childContextTypes = Object.keys(context).reduce( (context, key) => { - context[key] = noop; + context[key] = emptyFunction; return context; }, {}, @@ -47,11 +44,9 @@ function wrapElementWithContextProvider(element, context) { class ShallowRendererWrapper extends React.Component { static childContextTypes = childContextTypes; - getChildContext() { return context; } - render() { return this.props.children; }