optimize className check

facebook · Jun 9, 2015 · e704503 · e704503 · gpbl · Sep 22, 2015
1 parent 61d8de3
commit e704503
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/test/ReactTestUtils.js b/src/test/ReactTestUtils.js
@@ -174,7 +174,7 @@ var ReactTestUtils = {
         var instClassName = React.findDOMNode(inst).className;
         return (
           instClassName &&
-          (' ' + instClassName + ' ').indexOf(' ' + className + ' ') !== -1
+          (('' + instClassName).split(/\s+/)).indexOf(className) !== -1
         );
       }
       return false;

diff --git a/src/test/__tests__/ReactTestUtils-test.js b/src/test/__tests__/ReactTestUtils-test.js
@@ -187,6 +187,17 @@ describe('ReactTestUtils', function() {
 
   });
 
+  it('Test scryRenderedDOMComponentsWithClass with className contains \\n', function() {
+    var renderedComponent = ReactTestUtils.renderIntoDocument(<div>Hello <span className={`x
+    y`}>Jim</span></div>);
+    var scryResults = ReactTestUtils.scryRenderedDOMComponentsWithClass(
+      renderedComponent,
+      'x'
+    );
+    expect(scryResults.length).toBe(1);
+
+  });
+
   it('traverses children in the correct order', function() {
     var container = document.createElement('div');