New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Exports HTMLDOMPropertyConfig, SVGDOMPropertyConfig, and ARIADOMPropertyConfig in v16+ #10391

Closed
gfx opened this Issue Aug 5, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@gfx

gfx commented Aug 5, 2017

This is a feature request.

In React v15.6, HTMLDOMPropertyConfig, SVGDOMPropertyConfig, and ARIADOMPropertyConfig are available by import them directly, e.g. import ReactHTMLDOMPropertyConfig from 'react-dom/lib/HTMLDOMPropertyConfig'. In v16, however, they are no longer available.

I think they are not public parts of react-dom, but they are inevitable to implement https://github.com/Deschtex/html2react , a library to build React DOM from an HTML text.

See https://github.com/Deschtex/html2react/blob/master/src/react-properties-map.js#L1-L2 for how to use them.

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Aug 5, 2017

Member

I don't think we plan to expose them directly. Their format sometimes changes and we want to be able to make more under the hood changes to them in the future.

While it is a bit annoying I encourage you to just copy and paste them (and update if you notice changes on our side).

Member

gaearon commented Aug 5, 2017

I don't think we plan to expose them directly. Their format sometimes changes and we want to be able to make more under the hood changes to them in the future.

While it is a bit annoying I encourage you to just copy and paste them (and update if you notice changes on our side).

@gaearon gaearon closed this Aug 5, 2017

remarkablemark added a commit to remarkablemark/html-react-parser that referenced this issue Oct 1, 2017

feat(property-config): get property configs from `react-dom-core`
Because `react-dom` v16 no longer exposes `lib`, `react-dom-core`
is used. See issue: facebook/react#10391

Resolves #43
@remarkablemark

This comment has been minimized.

Show comment
Hide comment
@remarkablemark

remarkablemark Oct 1, 2017

@gfx I've created a package react-dom-core which copies and exposes modules in lib from react-dom@15.6.2.

remarkablemark commented Oct 1, 2017

@gfx I've created a package react-dom-core which copies and exposes modules in lib from react-dom@15.6.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment