Updated release script's suggested next version #14389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
commented
Dec 7, 2018
|
|
||
| if (!existsSync(join(cwd, 'build'))) { | ||
| await exec(`mkdir ./build`, {cwd}); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This change (and the one in check-out-packages) was just fixing an edge case I noticed while testing these changes.
Contributor
Author
|
This seems uncontroversial enough that I'm going to just land it. |
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on team discussion during today's sync, the next version number will be:
The release script still enables user overrides for these values. This only affects the suggested next version.