Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools: Better linking between browser Performance tab and DevTools Profiler #16483

Open
bvaughn opened this issue Aug 19, 2019 · 0 comments
Open
Labels

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Aug 19, 2019

Notes from a chat with Benoit:

It would be nice if starting profiling (or reload and profiling) in the browser auto-started profiling in DevTools.

It would also be nice if viewing a range of time in the Performance tab narrowed down the commits within the Profiler. At least starting the profilers at the same time would enable a manual match-up.

To my knowledge, none of the currently available APIs (including experimental) would enable us to support this level of integration.


If we were to make use of the DevTools protocol, we could Profiler.start and Profiler.stop the built-in profiler in sync with React's own profiler. Chrome's profiler also dispatches Profiler.consoleProfileStarted and Profiler.consoleProfileFinished events which we could use to follow the browser's profiler if we wanted to.

There do not appear to be any APIs/events for syncing the zoomed-in range.


Originally reported via bvaughn/react-devtools-experimental#37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants