New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve form inside of form error message #1665

Closed
yazaddaruvala opened this Issue Jun 9, 2014 · 4 comments

Comments

Projects
None yet
3 participants
@yazaddaruvala
Copy link

yazaddaruvala commented Jun 9, 2014

http://jsfiddle.net/U26kq/
Take a look at the error in the console. Its a terrible error "Uncaught object".

At least if you ask it to render a form inside a form from the console it will give you

Error: Invariant Violation: findComponentRoot(..., .2): Unable to find element. This probably means the DOM was unexpectedly mutated (e.g., by the browser), usually due to forgetting a <tbody> when using tables or nesting <p> or <a> tags. Try inspecting the child nodes of the element with React ID ``.

Which, while being better is not really helpful in this case.

@sophiebits

This comment has been minimized.

Copy link
Contributor

sophiebits commented Jun 9, 2014

You should see the full error message, and I do when going to that page:

image

I recall a Chrome bug that causes the error message not to be shown, though I thought it was fixed in the current builds. We'll do a better job of warning you exactly what the problem is when #101 gets properly implemented.

@sophiebits

This comment has been minimized.

Copy link
Contributor

sophiebits commented Jun 9, 2014

@syranide

This comment has been minimized.

Copy link
Contributor

syranide commented Jun 9, 2014

Yeah, this is a bug in the latest Chrome version, it happens arbitrarily and there's nothing we can do (as far as I've been able to determine) until Chrome fixes it. It happens to me too, annoyingly often.

@sophiebits

This comment has been minimized.

Copy link
Contributor

sophiebits commented Apr 1, 2015

This was fixed in Chrome. Also I added a better warning for this particular problem.

@sophiebits sophiebits closed this Apr 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment