[react-interactions] Re-label Flare as deprecated and remove from RN #17644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trueadm
requested review from
threepointone,
bvaughn,
sebmarkbage,
necolas,
gaearon,
lunaruan and
acdlite
trueadm
force-pushed
the
deprecated-responder
branch
from
379fa7c
to
5b18eb3
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5b18eb3:
|
Details of bundled changes.Comparing: e84327b...5b18eb3 react-native-renderer
react-dom
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (stable) |
threepointone
approved these changes
Dec 18, 2019
Details of bundled changes.Comparing: e84327b...5b18eb3 react-native-renderer
react-dom
Size changes (experimental) |
necolas
approved these changes
Dec 18, 2019
|
Just curious, would you mind tell a bit about the relationship between this PR and #17508? IMO, just like #17508 said, it learned from react-flare, but seems the new API like |
|
@NE-SmallTown React Flare and the Listener API (as per that other PR) are separate event systems that have entirely different designs. There's some overlap in how things work, but that's more a side-effect of those things being positives taken from React Flare that we want to keep in the future. We are still revising things, so the Listener API PR might also change too, thus why we have not merged it. |
|
Gotcha, thanks~ |
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up a bunch of stuff in our code base relating to React Flare. Specifically, it renames all the Flare call-sites to be "DEPRECATED" so it's clear that these APIs are going to go away at some point and shouldn't be used internally. It also removes React Flare from RN – where it was never used internally.
If we are to move forward with other event system experiments, this makes it clearer where the old system (Flare) lives and where other systems live; whereas they might have been confused previously.