New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReactPartialRenderer in production #10300

Merged
merged 1 commit into from Jul 27, 2017

Conversation

Projects
None yet
4 participants
@keyanzhang
Member

keyanzhang commented Jul 27, 2017

Fixes #10299. Seems like dangerousStyleValue and hyphenateStyleName are not dev-only helpers. In production, the entire __DEV__ branch gets removed and these 2 functions become undefined.

@keyanzhang keyanzhang requested a review from aickin Jul 27, 2017

@keyanzhang keyanzhang requested a review from trueadm Jul 27, 2017

@aickin

This comment has been minimized.

Show comment
Hide comment
@aickin

aickin Jul 27, 2017

Collaborator

Hahaha, I seriously just committed and was about to open an identical PR when I saw you beat me to it.

Ideally, we'd run tests in prod mode as part of the build to catch bugs like these, but in the mean time, this is the right fix. I approve!

Collaborator

aickin commented Jul 27, 2017

Hahaha, I seriously just committed and was about to open an identical PR when I saw you beat me to it.

Ideally, we'd run tests in prod mode as part of the build to catch bugs like these, but in the mean time, this is the right fix. I approve!

@aickin

aickin approved these changes Jul 27, 2017

@keyanzhang

This comment has been minimized.

Show comment
Hide comment
@keyanzhang

keyanzhang Jul 27, 2017

Member

@aickin :) thank you for your work on the server renderer!

cc @gaearon for potentially covering this in #10273. In the meantime, do you want me to add a sanity check in ReactDOMProduction-test?

Member

keyanzhang commented Jul 27, 2017

@aickin :) thank you for your work on the server renderer!

cc @gaearon for potentially covering this in #10273. In the meantime, do you want me to add a sanity check in ReactDOMProduction-test?

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Jul 27, 2017

Member

Ideally, we'd run tests in prod mode

#10273 :-)

Member

gaearon commented Jul 27, 2017

Ideally, we'd run tests in prod mode

#10273 :-)

@gaearon gaearon merged commit 3abbcc4 into facebook:master Jul 27, 2017

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Jul 27, 2017

Member

@keyanzhang Yes, please add a sanity check. Thanks!

Member

gaearon commented Jul 27, 2017

@keyanzhang Yes, please add a sanity check. Thanks!

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Jul 27, 2017

Member

I added tests in #10308.

Member

gaearon commented Jul 27, 2017

I added tests in #10308.

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Jul 27, 2017

Member

Released in 16.0.0-beta.2.

Member

gaearon commented Jul 27, 2017

Released in 16.0.0-beta.2.

@gaearon gaearon referenced this pull request Aug 1, 2017

Closed

React 16 Umbrella ☂️ (and 15.5) #8854

117 of 120 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment